-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow disable lang on Link #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! Looks good to me!! 🙂 Thank you for your contribution! 🎉
Is it possible to add at least one test here?
Just to be sure to don't break this behavior in the future! Also if you can add some explanation of this prop in the README docs, it will be very useful! 👏
@aralroca Added a test and docs. The |
@BjoernRave looks that via GitHub Actions all tests passed well... I'm going to take a look at this test. But your code looks good! Thank you a lot for your contribution!! |
@aralroca np, just saw, that I also committed the |
Don't worry, I just updated all deps before the 0.12.0 release 🙂 |
@all-contributors add @BjoernRave for code |
I've put up a pull request to add @BjoernRave! 🎉 |
I am using api routes to handle auth0. When routing to those routes, it results in a 404, due to the language being added.
This adds the option to disable the addition of the language.