Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disable lang on Link #89

Merged
merged 2 commits into from
Mar 21, 2020
Merged

Conversation

BjoernRave
Copy link
Contributor

I am using api routes to handle auth0. When routing to those routes, it results in a 404, due to the language being added.

This adds the option to disable the addition of the language.

@aralroca aralroca self-requested a review March 19, 2020 08:48
Copy link
Owner

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Looks good to me!! 🙂 Thank you for your contribution! 🎉

Is it possible to add at least one test here?

Just to be sure to don't break this behavior in the future! Also if you can add some explanation of this prop in the README docs, it will be very useful! 👏

@BjoernRave
Copy link
Contributor Author

BjoernRave commented Mar 21, 2020

@aralroca Added a test and docs. The builder › files tree › should build all the necessary files for all languages test is failing, not sure why

@aralroca
Copy link
Owner

@BjoernRave looks that via GitHub Actions all tests passed well... I'm going to take a look at this test. But your code looks good! Thank you a lot for your contribution!!

@aralroca aralroca merged commit 919a07a into aralroca:master Mar 21, 2020
@aralroca aralroca added this to the 0.12.0 milestone Mar 21, 2020
@BjoernRave
Copy link
Contributor Author

@aralroca np, just saw, that I also committed the yarn.lock file, not sure if it introduces any problems

@aralroca
Copy link
Owner

Don't worry, I just updated all deps before the 0.12.0 release 🙂

@aralroca
Copy link
Owner

@all-contributors add @BjoernRave for code

@allcontributors
Copy link
Contributor

@aralroca

I've put up a pull request to add @BjoernRave! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants