Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix DWI preprocessing using T1 rename to caps node #1146

Conversation

NicolasGensollen
Copy link
Member

@NicolasGensollen NicolasGensollen commented Apr 23, 2024

Closes #1142

The issue comes from the fact that the rename_into_caps node is supposed to have 5 inputs and 4 outputs in the computation DAG, while the code was defining 5 inputs and 5 outputs. This is due to the same list being used to define the input and output names.

This bug was introduced recently in #1074

@NicolasGensollen NicolasGensollen self-assigned this Apr 23, 2024
@NicolasGensollen NicolasGensollen added pipeline fix PR fixing a bug labels Apr 23, 2024
@NicolasGensollen NicolasGensollen added this to the v0.8.1 milestone Apr 23, 2024
@NicolasGensollen NicolasGensollen marked this pull request as ready for review April 23, 2024 15:50
@NicolasGensollen NicolasGensollen merged commit 3856557 into aramis-lab:maint-0.8 Apr 23, 2024
16 checks passed
@NicolasGensollen NicolasGensollen deleted the fix-dwi-preproc-using-t1-rename-to-caps-node branch April 23, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR fixing a bug pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant