[FIX] Fix logging in adni to bids #1181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
create_file
in the adni-to-bids converter is executed in a multiprocessing context but doesn't handle the logging of messages in the sense that child processes do not configure their own logger.This has a few consequences like the fact that messages logged from child processes aren't formatted or might even be missing.
This PR proposes a quick fix of re-configuring the clinica logger in child processes.
Ideally, we should have a process-safe logging architecture which would avoid race conditions (especially when logging to files for instance).
A classical solution is to dedicate a process to the logging task while other working processes send their logging messages through a Queue.