[DOC] ADNI-to-BIDS : add Field Mapping (FMAP) specificities #1199
Conversation
There was a problem hiding this comment.
Thanks @AliceJoubert !
I think this looks good but I would be a bit clearer on the fact that FMAP conversion is new and experimental (see comment).
|
Thanks for the review @NicolasGensollen ! I modified to add your suggestion. Do you see anything else ? |
| @@ -100,6 +102,11 @@ The user can easily modify this file if they want to convert additional clinical | |||
| For further details regarding clinica data, we recommend to look at the [ADNI Data Package | |||
| ](https://adni.bitbucket.io/index.html) developed by the Alzheimer's Disease Neuroimaging Initiative. | |||
|
|
|||
| ??? failure "Warning : Field Mapping modality" | |||
There was a problem hiding this comment.
I don't see this block in the rendered documentation: https://aramislab.paris.inria.fr/clinica/docs/public/PR-1199/Converters/ADNI2BIDS/
There was a problem hiding this comment.
I don't see it either, as well as all the changes I made in the last commit (ex : removing the "except for FMAP" part as suggested). Did I miss something I should have done for it to appear ?
There was a problem hiding this comment.
Indeed, there is a bug in the automatic documentation deployment pipeline... 😱 I'll open a PR to fix it.
I've updated the docs for this PR manually and the changes you made seem to be there.
Could you just double check that everything looks good in the rendered page ?
There was a problem hiding this comment.
I am not sure if it is still relevant now that you merged the PR but no I can't see the new changes in the rendered page. I will rebase a bit later :-)
There was a problem hiding this comment.
That's weird, I can see them.
There was a problem hiding this comment.
LGTM, thanks @AliceJoubert !
I'm gonna merge since I can see the changes in the rendered doc and they look good to me.
Complete ADNI-to-BIDS documentation :