Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add FreeSurfer dependency to dwi-connectome documentation #1247

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[DOC] Add FreeSurfer dependency to dwi-connectome documentation #1247

merged 1 commit into from
Aug 1, 2024

Conversation

NicolasGensollen
Copy link
Member

Fixes #1246

@NicolasGensollen NicolasGensollen self-assigned this Aug 1, 2024
AliceJoubert
AliceJoubert approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@AliceJoubert AliceJoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ! Unless I missed it and did not read properly there should also have been an addition for the labels ?

@NicolasGensollen
Copy link
Member Author

LGTM, thanks ! Unless I missed it and did not read properly there should also have been an addition for the labels ?

Thanks for the review @AliceJoubert !
I haven't done it yet, but anyway, I'd have done it in a dedicated PR, so I'll merge this one.

@NicolasGensollen NicolasGensollen merged commit 1e2b351 into aramis-lab:dev Aug 1, 2024
13 of 15 checks passed
@NicolasGensollen NicolasGensollen deleted the fix-doc-dwi-connectome branch August 1, 2024 13:54
AliceJoubert pushed a commit to AliceJoubert/clinica that referenced this pull request Aug 22, 2024
@NicolasGensollen @AliceJoubert
[DOC] Add FreeSurfer dependency to dwi-connectome documentation (aram…
4710d27 
…is-lab#1247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliceJoubert AliceJoubert AliceJoubert approved these changes

Assignees

@NicolasGensollen NicolasGensollen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing third-party dependency in documentation of DWIConnectome
2 participants
@NicolasGensollen @AliceJoubert