Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Adding Support page #1297

Merged
merged 28 commits into from
Sep 25, 2024
Merged

[DOC] Adding Support page #1297

merged 28 commits into from
Sep 25, 2024

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented Sep 16, 2024 •
edited
Loading

  • Support.md as snippet
  • Contributing.md included in docs

@AliceJoubert AliceJoubert added the doc Documentation (wiki, source code, etc.) label Sep 16, 2024
@AliceJoubert AliceJoubert self-assigned this Sep 16, 2024
@AliceJoubert AliceJoubert marked this pull request as ready for review September 19, 2024 13:18
NicolasGensollen
NicolasGensollen reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pursuing this very useful refactoring @AliceJoubert !

README.md Outdated Show resolved Hide resolved
docs/Converters/ADNI2BIDS.md Outdated Show resolved Hide resolved
docs/Software/CONTRIBUTING.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
docs/Software/InteractingWithClinica.md Show resolved Hide resolved
NicolasGensollen
NicolasGensollen reviewed Sep 24, 2024
View reviewed changes
docs/Software/contributing.md Outdated Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
NicolasGensollen
NicolasGensollen reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AliceJoubert !
I've tested the rendered version a bit and it seems to work fine.
I just noticed a couple small bugs (see comments).
Also, it looks like the link on the home page "Data handling tools for BIDS and CAPS compliant datasets" is broken atm.

CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/Home/index.md Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
@AliceJoubert
Copy link
Contributor Author

Thanks for the review @NicolasGensollen ! Normally I fixed everything. Do you see anything else ?

@NicolasGensollen
Copy link
Member

Thanks for the review @NicolasGensollen ! Normally I fixed everything. Do you see anything else ?

Great ! Thanks @AliceJoubert !
The link under "clinica at conferences" seems to be broken as well

@NicolasGensollen
Copy link
Member

And the one above also ("t1-freesurfer....")

NicolasGensollen
NicolasGensollen approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AliceJoubert !

@NicolasGensollen NicolasGensollen merged commit 393e4c4 into aramis-lab:dev Sep 25, 2024
13 of 15 checks passed
@AliceJoubert AliceJoubert deleted the doc_support branch September 25, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasGensollen NicolasGensollen NicolasGensollen approved these changes

Assignees

@AliceJoubert AliceJoubert

Labels
doc Documentation (wiki, source code, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliceJoubert @NicolasGensollen