[TEST][REF] Move functions specific to OASIS1 converter in a dedicated utils file and add unit tests #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AliceJoubert
commented
Oct 7, 2024
•
AliceJoubert
commented
- Move to module specific to OASIS1
- Remove parts specific to OASIS3 (never used)
- Add tests.
There was a problem hiding this comment.
Thanks @AliceJoubert !
The code looks good. I made a couple suggestions on the tests in order to improve readability and use fixtures in a more "traditional" way.
test/unittests/iotools/converters/oasis_to_bids/test_oasis_to_bids_utils.py
Outdated
Show resolved
Hide resolved
test/unittests/iotools/converters/oasis_to_bids/test_oasis_to_bids_utils.py
Outdated
Show resolved
Hide resolved
test/unittests/iotools/converters/oasis_to_bids/test_oasis_to_bids_utils.py
Outdated
Show resolved
Hide resolved
|
Thanks for the review @NicolasGensollen , do you see anything else ? |
NicolasGensollen
approved these changes
Oct 9, 2024
NicolasGensollen
pushed a commit
to NicolasGensollen/clinica
that referenced
this pull request
Oct 24, 2024
…d utils file and add unit tests (aramis-lab#1313) * Move functions from bids_utils to oasis_to_bids_utils + create test script * WIP 1 * Remove unused optional argument subj_to_remove * WIP2 * Finish tests * Fix * Add last test * Changes upon suggestions * Changes 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.