Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] AIBL-to-BIDS : add unit tests to functions related to creating sessions.tsv files #1347

Merged
merged 6 commits into from
Oct 25, 2024
Merged

[TEST] AIBL-to-BIDS : add unit tests to functions related to creating sessions.tsv files #1347

merged 6 commits into from
Oct 25, 2024

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented Oct 23, 2024 •
edited
Loading

Close #1349

!!! Function modifications for _compute_ages_at_each_exam and _compute_exam_date_from_baseline

@AliceJoubert AliceJoubert self-assigned this Oct 23, 2024
@AliceJoubert AliceJoubert marked this pull request as ready for review October 24, 2024 09:43
NicolasGensollen
NicolasGensollen reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests @AliceJoubert !

I think the PR looks good. I made a small suggestion on how to represent the list of exam dates which we can either implement here or keep for later depending on how you want to proceed.

There are also a lot of TODOs in the code. Are you planning to address them soon ?
If not, it could be better to open dedicated issues that we can track and not forget about. These TODO comments usually get added and stay there forever as nobody remembers what they meant but nobody feels legitimate to remove them either...

clinica/iotools/converters/aibl_to_bids/utils/clinical.py Show resolved Hide resolved
test/unittests/iotools/converters/aibl_to_bids/test_aibl_utils.py Show resolved Hide resolved
@AliceJoubert
Copy link
Contributor Author

AliceJoubert commented Oct 24, 2024 •
edited
Loading

Thanks for the review @NicolasGensollen !

I plan on addressing the TODOs right after this PR gets merged with associated issues so they are not here to stay for a long time.

Do you see anything else on this PR (especially for the functions modifications) ?

NicolasGensollen
NicolasGensollen approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AliceJoubert !

@NicolasGensollen NicolasGensollen merged commit 09fc59c into aramis-lab:dev Oct 25, 2024
11 of 14 checks passed
@AliceJoubert AliceJoubert deleted the aibl_sessions branch October 25, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasGensollen NicolasGensollen NicolasGensollen approved these changes

Assignees

@AliceJoubert AliceJoubert

Labels
converter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEST] AIBL-to-BIDS utils are lacking unit tests for sessions.tsv creation
2 participants
@AliceJoubert @NicolasGensollen