Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Correct the pet-linear pipeline #1348

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

ravih18
Copy link
Contributor

@ravih18 ravih18 commented Oct 23, 2024

Closes #1345

@NicolasGensollen NicolasGensollen added the fix PR fixing a bug label Oct 24, 2024
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this bug @ravih18 !
The PR LGTM with a small suggestion to avoid a KeyError when calling the pipeline from the Python API.

clinica/pipelines/pet/linear/pipeline.py Outdated Show resolved Hide resolved
@NicolasGensollen NicolasGensollen added this to the v0.9.2 milestone Oct 24, 2024
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ravih18 !

@NicolasGensollen NicolasGensollen merged commit 00e1839 into aramis-lab:dev Oct 24, 2024
12 of 14 checks passed
NicolasGensollen added a commit to NicolasGensollen/clinica that referenced this pull request Oct 24, 2024
* Use T1W linear for non linear registration

* run precommit

* Update clinica/pipelines/pet/linear/pipeline.py

* Update clinica/pipelines/pet/linear/pipeline.py

---------

Co-authored-by: Gensollen <[email protected]>
NicolasGensollen added a commit to NicolasGensollen/clinica that referenced this pull request Oct 25, 2024
NicolasGensollen added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct pet-linear
2 participants