Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] add unit test for /arana/pkg/dataset. #708

Closed
dongzl opened this issue Jul 12, 2023 · 3 comments
Closed

[Test] add unit test for /arana/pkg/dataset. #708

dongzl opened this issue Jul 12, 2023 · 3 comments
Assignees
@csynineyang
Labels
good first issue Good for newcomers test Unit test.
Milestone
0.2.0

Comments

@dongzl
Copy link
Contributor

dongzl commented Jul 12, 2023

What would you like to be added:

Why is this needed:
image

add unit test for /arana/pkg/dataset package, specifically for:

  • filter.go
  • reduce.go
  • transform.go
@dongzl dongzl added the test Unit test. label Jul 12, 2023
@dongzl dongzl added this to the 0.2.0 milestone Jul 12, 2023
@dongzl dongzl added the good first issue Good for newcomers label Jul 13, 2023
@csynineyang
Copy link
Contributor

assign me

@maronghe
Copy link
Contributor

  1. 确认下覆盖率；
  2. reduce_test

@csynineyang
Copy link
Contributor

reduce_test：3个case，min/max/sum

csynineyang added a commit to csynineyang/arana that referenced this issue Aug 3, 2023
@csynineyang
add unit test for function (arana-db#708)
7a81b15
dongzl pushed a commit that referenced this issue Aug 6, 2023
@csynineyang
add unit test for function (#708) (#733)
3ea47a2 
* add unit test for function (#708)

* formatter import
@Mulavar Mulavar closed this as completed Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csynineyang csynineyang

Labels
good first issue Good for newcomers test Unit test.
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
4 participants
@dongzl @maronghe @Mulavar @csynineyang