[Feature] Support HashJoin For Shards #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
February 26, 2023 14:16
# Conflicts: # pkg/runtime/optimize/dml/select.go
# Conflicts: # pkg/runtime/optimize/dml/select.go
# Conflicts: # pkg/runtime/optimize/shard_visitor_test.go
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 36.77% 35.15% -1.63%
==========================================
Files 229 245 +16
Lines 24016 25857 +1841
==========================================
+ Hits 8832 9089 +257
- Misses 14177 15710 +1533
- Partials 1007 1058 +51
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
dongzl
approved these changes
Jul 21, 2023
maronghe
approved these changes
Jul 22, 2023
| @@ -413,3 +463,7 @@ func (f *FunctionCallExpressionAtom) Restore(flag RestoreFlag, sb *strings.Build | |||
| func (f *FunctionCallExpressionAtom) phantom() expressionAtomPhantom { | |||
| return expressionAtomPhantom{} | |||
| } | |||
|
|
|||
| func (f *FunctionCallExpressionAtom) Clone() ExpressionAtom { | |||
| panic("implement me") | |||
There was a problem hiding this comment.
Implement later or needn't ?
AlexStocks
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持跨库hashjoin功能
#656