Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go test #702

Merged
merged 1 commit into from
Jul 8, 2023
Merged

fix go test #702

merged 1 commit into from
Jul 8, 2023

Conversation

DemanWei
Copy link
Contributor

@DemanWei DemanWei commented Jul 8, 2023

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (57dee39) 37.02% compared to head (febb624) 37.09%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   37.02%   37.09%   +0.06%     
==========================================
  Files         230      230              
  Lines       24429    24429              
==========================================
+ Hits         9045     9061      +16     
+ Misses      14370    14350      -20     
- Partials     1014     1018       +4     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DemanWei DemanWei merged commit ad211a5 into arana-db:master Jul 8, 2023
11 checks passed
DemanWei added a commit that referenced this pull request Jul 9, 2023
This reverts commit ad211a5.
DemanWei added a commit that referenced this pull request Jul 9, 2023
* Revert "fix go test (#702)"

This reverts commit ad211a5.

* fix CodeQL problems (#703)

* fix go test

* Update codeql-analysis.yml

* fix CodeQL problems
Lvnszn pushed a commit to Lvnszn/arana that referenced this pull request Jul 22, 2023
Lvnszn pushed a commit to Lvnszn/arana that referenced this pull request Jul 22, 2023
* Revert "fix go test (arana-db#702)"

This reverts commit ad211a5.

* fix CodeQL problems (arana-db#703)

* fix go test

* Update codeql-analysis.yml

* fix CodeQL problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants