feat(log) : support logging with context(#596) #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 36.77% 37.20% +0.43%
==========================================
Files 229 230 +1
Lines 24016 24504 +488
==========================================
+ Hits 8832 9117 +285
- Misses 14177 14343 +166
- Partials 1007 1044 +37
☔ View full report in Codecov by Sentry. |
Mulavar
requested review from
jjeffcaii,
dongzl,
georgehao,
AlexStocks,
Lvnszn,
maronghe and
csynineyang
Lvnszn
reviewed
Jul 12, 2023
jjeffcaii
approved these changes
Jul 13, 2023
jjeffcaii
changed the title
1. add composite logger to manage main/sql/tx logger 2. support to parse and propagate the trace context to logging 3. make the logger achieve context level isolation
|
Kudos, SonarCloud Quality Gate passed!
|
dongzl
approved these changes
Jul 17, 2023
maronghe
approved these changes
Jul 17, 2023
Lvnszn
pushed a commit
to Lvnszn/arana
that referenced
this pull request
Jul 22, 2023
1. add composite logger to manage main/sql/tx logger 2. support to parse and propagate the trace context to logging 3. make the logger achieve context level isolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #596
Special notes for your reviewer:
Does this PR introduce a user-facing change?: