Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for function (#706) #739

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

csynineyang
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.08% 🎉

Comparison is base (b9526c8) 36.96% compared to head (53b93f8) 38.04%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   36.96%   38.04%   +1.08%     
==========================================
  Files         251      251              
  Lines       26236    26236              
==========================================
+ Hits         9697     9981     +284     
+ Misses      15497    15135     -362     
- Partials     1042     1120      +78     
Files Changed Coverage Δ
pkg/boot/watcher.go 51.35% <100.00%> (+50.85%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csynineyang
Copy link
Contributor Author

github.com/arana-db/arana/pkg/boot/boot.go (64.7%)
github.com/arana-db/arana/pkg/boot/discovery.go (64.6%)
github.com/arana-db/arana/pkg/boot/discovery_import.go (63.9%)
github.com/arana-db/arana/pkg/boot/discovery_watch.go (63.9%)
github.com/arana-db/arana/pkg/boot/misc.go (78.1%)
github.com/arana-db/arana/pkg/boot/watcher.go (68.1%)

@AlexStocks AlexStocks merged commit 93834f8 into arana-db:master Aug 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants