Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test #753

Merged
merged 9 commits into from
Sep 4, 2023
Merged

Add unit test #753

merged 9 commits into from
Sep 4, 2023

Conversation

dongzl
Copy link
Contributor

@dongzl dongzl commented Aug 25, 2023

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@dongzl dongzl added the test Unit test. label Aug 25, 2023
@dongzl dongzl added this to the 0.2.0 milestone Aug 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.31% 🎉

Comparison is base (f285e71) 38.29% compared to head (e476dbd) 38.60%.
Report is 2 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   38.29%   38.60%   +0.31%     
==========================================
  Files         253      259       +6     
  Lines       26312    26468     +156     
==========================================
+ Hits        10076    10218     +142     
- Misses      15118    15129      +11     
- Partials     1118     1121       +3

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

baerwang
baerwang approved these changes Aug 27, 2023
View reviewed changes
pkg/util/match/slice_match_test.go Outdated Show resolved Hide resolved
jjeffcaii
jjeffcaii requested changes Aug 27, 2023
View reviewed changes
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short word, pls using testify lib instead.

pkg/util/env/env_test.go Show resolved Hide resolved
pkg/util/file/file_test.go Outdated Show resolved Hide resolved
@dongzl dongzl requested a review from jjeffcaii August 29, 2023 06:09
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dongzl dongzl mentioned this pull request Sep 4, 2023
Open
@jjeffcaii jjeffcaii merged commit ca6a25c into arana-db:master Sep 4, 2023
12 checks passed
@dongzl dongzl deleted the add-unit-test branch November 18, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjeffcaii jjeffcaii jjeffcaii approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@baerwang baerwang baerwang approved these changes

Assignees
No one assigned
Labels
test Unit test.
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dongzl @codecov-commenter @jjeffcaii @AlexStocks @baerwang