Use matplotlib plot to save, avoiding Kaleido #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib to avoid use of Kaleido, as Apple M3 have issues with Kaleido
lib to avoid use of Kaleido, as Apple M3 have issues with Kaleido
itutu-tienday
requested changes
Jun 24, 2024
| @@ -75,6 +75,8 @@ filelock = "*" | |||
| ruamel-yaml = "^0.18.5" | |||
| pymatreader = "^0.0.32" | |||
| xmltodict = "*" | |||
| matplotlib = "*" | |||
There was a problem hiding this comment.
Once commented, but first, I think it would be good if you could share the following points with us.
- Test Patterns
- Are there any missing points to be checked?
- Processing performance is also a target to be checked (cases where a large number of images are processed are also assumed)
- Test results of the above patterns
- Comparison of kaleido/matplotlib processing results, etc.
For the above test, it may be necessary to secure an environment in which kaleido works (e.g. Mac M2?).
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple silicon M3 seems to have issues with Kaleido. As Kaleido is not currently being maintained, these issues are likely to persist or worsen in the future.
Kaleido was used to work with Plotly and save images. However, the save function can be done with Matplot lib, which is well maintained.
This required updating poetry files, as well as the python plot files.