Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use singleton in llama_cpp #1013

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix: use singleton in llama_cpp #1013

merged 2 commits into from
Jun 25, 2024

Conversation

dartpain
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Why was this change needed? (You can also link to an open issue here)

  • Other information:

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 1:41pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 1:41pm

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 21.83%. Comparing base (651eb33) to head (5aa8871).
Report is 7 commits behind head on main.

Files Patch % Lines
application/llm/llama_cpp.py 38.09% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
+ Coverage   21.69%   21.83%   +0.14%     
==========================================
  Files          80       80              
  Lines        3632     3645      +13     
==========================================
+ Hits          788      796       +8     
- Misses       2844     2849       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@starkgate
Copy link
Contributor

@dartpain Looks good, thanks! Much cleaner than my proposal, too. This will be a great improvement for many people.

@dartpain dartpain requested a review from pabik June 25, 2024 16:39
@dartpain dartpain merged commit 2985e3b into main Jun 25, 2024
16 checks passed
@dartpain dartpain deleted the fix/singleton-llama-cpp branch June 25, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Local model is recreated for each request, causing delay and out of memory errors
3 participants