Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(Sharing): Introducing Promptable conversations #1039

Merged
merged 11 commits into from
Jul 29, 2024

Conversation

ManishMadan2882
Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 commented Jul 19, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Backend

  1. Made POST /api/share endpoint compatible with promptable sharings

    • If the api key is existing with the same attributes(prompt_id, chunks, source), shared conversation depends on that api_key. New shared conversation doc is created, responding with the UUID as identifier.
    • else if the api key is existing and a shared conversation document with exactly same fields is already existing, avoid re-creating the shared_conversation and return the pre_existing UUID as identifier.
    • generate a new api key, assign its key to the new shared conversation, respond with the new document's uuid.
  2. Modified the GET /api/shared_conversation/<string:identifier> endpoint to send the api_key if present in response.

  3. complete_stream() : Prevent storing request made through api_key

Frontend

  • Structured the redux slice for sharedConversations.
    Screenshot from 2024-07-26 15-08-57
  • Integrated the stream route, for prompting through shared conversations' api-keys.
  • Further queries after the originally shared ones, will be saved in localStorage
  • Why was this change needed? (You can also link to an open issue here)
    Allow sharing conversations which can be prompted further

Copy link

vercel bot commented Jul 19, 2024

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 8:24pm

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you!

@dartpain dartpain merged commit f75ed4b into arc53:main Jul 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants