Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refining the scrolling functionality while streaming #1113

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

ManishMadan2882
Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 commented Sep 4, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    • As per the current logic, the endMessageRef was referred while scrolling
    • In this PR, referring to the conversationRef alone to control scrolling
    • The scrollIntoView method should handle the following cases:
      • When the status is idle or a new prompt is just added: Smoothly scroll to the bottom of conversationRef
      • While streaming: when the response is getting generated, the scroll should stick to the bottom of the conversation container, to make the streaming more consistent.
  • Why was this change needed? (You can also link to an open issue here)
    • Frictionless streaming.
  • Other information:
    Fixed the overflow of code, without any language match.
    Minor change in react-widget/publish.sh : Refresh the package json and package-lock after each publish

Copy link

vercel bot commented Sep 4, 2024

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 10:05pm

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@dartpain dartpain merged commit 490e58f into arc53:main Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants