Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(1169): Handle state of empty tables #1178

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

anasKhafaga
Copy link
Contributor

  • What kind of change does this PR introduce?
    Feature update: Added a "No existing ..." messages in multiple locales (English, Spanish, Japanese, and Chinese), and updated both the APIKeys.tsx and Documents.tsx components to display a message when there are no API keys or documents available.

  • Why was this change needed?
    related to Add a default message in the UI when no data is fetched, Example: Settings > Chatbots - No existing Chatbots. #1169. This change was needed to improve user experience by providing feedback when there are no existing chatbots or documents in their respective sections, ensuring users are clearly informed when no data is available across multiple languages.

  • Other information:
    image

Copy link

vercel bot commented Oct 1, 2024

@anasKhafaga is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 9:58am

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anasKhafaga
Requesting a minor change, there is slight border overlap probably because of border-r class in the td
image
In the right bottom the two borders are overlapping.
Thankyou!

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anasKhafaga !

@dartpain dartpain merged commit eb8c2a9 into arc53:main Oct 2, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants