Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FaissStore to enhance error handling, add improve type hints, and document methods for better maintainability and usability #1183

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

Devparihar5
Copy link
Contributor

  • Refactor FaissStore to enhance error handling.
  • Improve type hints for method signatures.
  • Add method documentation for better clarity and maintainability.
  • Enhance the initialization process to handle exceptions gracefully.
  • Ensure robust loading and creation of the FAISS index.
  • Aim to improve usability and facilitate future development.

…s, and document methods for better maintainability and usability
fix: Refactor FaissStore to enhance error handling, improve type hint…
fix: Fix unused exception variable in FaissStore.
Copy link

vercel bot commented Oct 1, 2024

@Devparihar5 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 5:09pm

ManishMadan2882

This comment was marked as outdated.

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect,
Thanks @Devparihar5 !

@dartpain dartpain merged commit 8c8bf87 into arc53:main Oct 2, 2024
5 checks passed
@dartpain
Copy link
Contributor

@holopin-bot @Devparihar5 Thank you!

Copy link

holopin-bot bot commented Oct 21, 2024

Congratulations @Devparihar5, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jehuou51980cjzn0q26c36

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain
Copy link
Contributor

Hey @Devparihar5 please fill in this form if you are interested in a t-shirt
https://airtable.com/appikMaJwdHhC1SDP/pagoblCJ9W29wf6Hf/form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants