Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: added ExcelParser(tested) to read .xlsx files #1184

Merged
merged 4 commits into from
Oct 6, 2024
Merged

new: added ExcelParser(tested) to read .xlsx files #1184

merged 4 commits into from
Oct 6, 2024

Conversation

Devparihar5
Copy link
Contributor

Added ExcelParser Class: Implemented an ExcelParser for reading Excel (.xlsx) files using Pandas.

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024

Someone is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@Devparihar5 Devparihar5 closed this Oct 1, 2024
@Devparihar5 Devparihar5 reopened this Oct 1, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 9:13pm

@dartpain
Copy link
Contributor

dartpain commented Oct 4, 2024

Thats a really cool PR!
Thank you!

Just one comment - can you remove mlb_teams_2012.csv:Zone.Identifier file thats in the commit.
Otherwise really appreciate that you went through the whole app to find the relevant things to change.

@github-actions github-actions bot removed the repo label Oct 4, 2024
@Devparihar5
Copy link
Contributor Author

Thats a really cool PR! Thank you!

Just one comment - can you remove mlb_teams_2012.csv:Zone.Identifier file thats in the commit. Otherwise really appreciate that you went through the whole app to find the relevant things to change.

It's done, thank you for the appreciation, I have multiple ideas for that in future definitely I'm going to add multiple features

dartpain
dartpain approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dartpain dartpain merged commit c9e95a9 into arc53:main Oct 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartpain dartpain dartpain approved these changes

Assignees
No one assigned
Labels
application Application frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Devparihar5 @dartpain