Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hard breaking long string words and intelligent word breaks #1259

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

utin-francis-peter
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix readability of user contents and overflow of long string characters with no whitespace nor hyphen

  • Why was this change needed? (You can also link to an open issue here)
    Improves reading XP.

  • Other information:
    For a full video review of the fix as it's a bit controversial—considering a legacy approach was used—kindly click on the link below:

https://drive.google.com/file/d/1_XY7y2yaQkX1rp_U3EkcNf8HnQTL_wYa/view?usp=sharing

closes: #1222

…ipping hyphenated/whitespace to next line for good reading XP
Copy link

vercel bot commented Oct 7, 2024

@utin-francis-peter is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @utin-francis-peter.

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 3:10pm

@dartpain
Copy link
Contributor

dartpain commented Oct 7, 2024

There is an error on npm run build

src/conversation/ConversationBubble.tsx(64,13): error TS2353: Object literal may only specify known properties, and ''word-break'' does not exist in type 'Properties<string | number, string & {}>'.
Error: Command "npm run build" exited with 2

@dartpain
Copy link
Contributor

@holopin-bot @utin-francis-peter Thank you!

Copy link

holopin-bot bot commented Oct 21, 2024

Congratulations @utin-francis-peter, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm2jekp0409640clh88ov5pa8

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Very long continues string (long word) unexpected behaviour
3 participants