-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Table redesign #1300
Feature: Table redesign #1300
Conversation
@AkashJana18 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AkashJana18,
Just reviewed, have few points:
- Make sure the UI matches the figma
- The Add new button triggers the Upload modal
- Search bar filters documents depending on document name
Also try to sync with main as there some tab design related changes in this file from your previous PR.
Thanks!
Hey @ManishMadan2882 the required changes are made can you please check it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AkashJana18
Have few points:
- There is an app crash on creating a new API Key
- When the modal opens on clicking the New Document button, it partially covers the screen
- For table re-design, please follow figma, but you can ignore pagination for now as it will need few endpoints.
- Also, please sync your branch with upstream main, there are conflicts.
Thanks!
Hey @AkashJana18 how is it going? |
@dartpain working on it PR will updated soon |
Hey @ManishMadan2882 I have made the required changes
|
Hi @AkashJana18
|
Hey @ManishMadan2882 conflicts have been resolved. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
=======================================
Coverage 33.45% 33.45%
=======================================
Files 64 64
Lines 3273 3273
=======================================
Hits 1095 1095
Misses 2178 2178 ☔ View full report in Codecov by Sentry. |
Hey @AkashJana18 Fails with
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ManishMadan2882 how do i revert the changes made while resolving conflict. I think i made error while resolving conflict if you can revert the change in APIkeys.tsx i can fix it. |
First revert your merge commit, then Follow this on VSC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, Thanks @AkashJana18
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Changed hover effect, added search bar in 2 pages and added button as per requirement.
Why was this change needed? (You can also link to an open issue here)
Fixes: 🚀 Feature: Table redesign #1286
Other information: