Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature closing the upload document component after clicking ouside #1376

Closed
wants to merge 5 commits into from

Conversation

prathamesh424
Copy link
Contributor

@prathamesh424 prathamesh424 commented Oct 24, 2024

Added feature closing the upload document component after clicking ouside
[Fixed:issue #1231 ]
As the issue assign to me but someone completed the other work but not added the closing of uploading component after clicking outside the component .

Result : after issue solve

Screen.Recording.2024-10-24.153527.mp4

Copy link

vercel bot commented Oct 24, 2024

@prathamesh424 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@prathamesh424
Copy link
Contributor Author

@dartpain @ManishMadan2882 check out changes

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.45%. Comparing base (a972bb8) to head (c6478fe).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   33.45%   33.45%           
=======================================
  Files          64       64           
  Lines        3273     3273           
=======================================
  Hits         1095     1095           
  Misses       2178     2178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ManishMadan2882
Copy link
Collaborator

@prathamesh424
The issue was focused on creating a Base Modal component, like a wrapper component which can be reused by other modal components, the base modal should match the styling of Upload modal as mentioned by @pabik in #1231 and it should get closed on clicking outside the modal.
Thanks.

@prathamesh424
Copy link
Contributor Author

prathamesh424 commented Oct 24, 2024

@ManishMadan2882 sir is this PR getting marged

@prathamesh424 prathamesh424 changed the title Added feature closing the upload document component after clicking ouside [Fixed:issue#1231] Added feature closing the upload document component after clicking ouside Oct 25, 2024
@dartpain
Copy link
Contributor

@prathamesh424 @ManishMadan2882 is the maintainer of this project.

@dartpain dartpain closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants