Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Changed environment variable names OPENAI_API_BASE and OPENAI… #296

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

larinam
Copy link
Collaborator

@larinam larinam commented Aug 5, 2023

…_API_VERSION to AZURE_OPENAI_API_BASE and AZURE_OPENAI_API_VERSION"

This reverts commit ce8b29e.

Please see the documentation for langchain.embeddings.openai.OpenAIEmbeddings to get the point of the environment varibles naming. These names should not be changed.

…_API_VERSION to AZURE_OPENAI_API_BASE and AZURE_OPENAI_API_VERSION"

This reverts commit ce8b29e.
@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2023 0:11am

@larinam
Copy link
Collaborator Author

larinam commented Aug 8, 2023

Hi @dartpain ,
Could you review this one? If additional explanation is required, I can provide it.
The thing with naming is that in the langchain package, it is expected to have particular names for the environment variables. When the change which I suggest to revert here was introduced, it led to the broken Azure support in DocsGPT. The revert of the commit will recover functionality which was in place before the change introduced by the commit, which is suggested to be reverted in this pull request.
Thank you for your time reviewing these changes and maintaining this project!

@dartpain
Copy link
Contributor

dartpain commented Aug 8, 2023

Thank you for you explanation, it seems to be working fine for me on the dev environment and quickstart one

#276 I just want to be careful not to break it again.

@dartpain dartpain merged commit 33dce10 into arc53:main Aug 8, 2023
2 checks passed
@larinam larinam deleted the revert_breaking_renaming_azure_change branch September 3, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants