Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Empty Spaces Passed in the Input Field #384

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fixed Empty Spaces Passed in the Input Field #384

merged 1 commit into from
Oct 4, 2023

Conversation

ArnabBCA
Copy link
Contributor

@ArnabBCA ArnabBCA commented Oct 3, 2023

Issue ID #382

The Input Field now handles Empty Spaces

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 3:27pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 3:27pm

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #384 (03a5236) into main (16fe77e) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

❗ Current head 03a5236 differs from pull request most recent head e95e084. Consider uploading reports for the commit e95e084 to get more accurate results

@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   16.01%   16.01%           
=======================================
  Files          59       59           
  Lines        2667     2667           
=======================================
  Hits          427      427           
  Misses       2240     2240           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dartpain
Copy link
Contributor

dartpain commented Oct 3, 2023

I think we still send the empty spaces if a user submits it as a request (it will basically send no empty spaces otherwise), maybe we should rather stop the send button from working if its empty. Somewhere around handleQuestion when it gets triggered in Conversation.tsx.

thank you!

@ArnabBCA
Copy link
Contributor Author

ArnabBCA commented Oct 4, 2023

I think we still send the empty spaces if a user submits it as a request (it will basically send no empty spaces otherwise), maybe we should rather stop the send button from working if its empty. Somewhere around handleQuestion when it gets triggered in Conversation.tsx.

thank you!

Thank you for your feedback I will look into the code and make necessary changes.

@ArnabBCA ArnabBCA closed this Oct 4, 2023
@ArnabBCA
Copy link
Contributor Author

ArnabBCA commented Oct 4, 2023

I think we still send the empty spaces if a user submits it as a request (it will basically send no empty spaces otherwise), maybe we should rather stop the send button from working if its empty. Somewhere around handleQuestion when it gets triggered in Conversation.tsx.

thank you!

I have moved the trim logic in the handleQuestion function as you told, now even if the user press enter or click button the handleQuestion will first check whether the question is empty or not then it will proceed else it will return . it will also not send any request to the backend also

@dartpain
Copy link
Contributor

dartpain commented Oct 4, 2023

@holopin-bot @ArnabBCA Thank you!

@holopin-bot
Copy link

holopin-bot bot commented Oct 4, 2023

Congratulations @ArnabBCA, you just earned a badge! Here it is: https://holopin.io/claim/clncd3sk221020flbegngq57o

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain dartpain merged commit ec2762c into arc53:main Oct 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants