-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Empty Spaces Passed in the Input Field #384
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage 16.01% 16.01%
=======================================
Files 59 59
Lines 2667 2667
=======================================
Hits 427 427
Misses 2240 2240 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I think we still send the empty spaces if a user submits it as a request (it will basically send no empty spaces otherwise), maybe we should rather stop the send button from working if its empty. Somewhere around handleQuestion when it gets triggered in Conversation.tsx. thank you! |
Thank you for your feedback I will look into the code and make necessary changes. |
I have moved the trim logic in the handleQuestion function as you told, now even if the user press enter or click button the handleQuestion will first check whether the question is empty or not then it will proceed else it will return . it will also not send any request to the backend also |
@holopin-bot @ArnabBCA Thank you! |
Congratulations @ArnabBCA, you just earned a badge! Here it is: https://holopin.io/claim/clncd3sk221020flbegngq57o This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Issue ID #382
The Input Field now handles Empty Spaces