Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the copy response feature #503

Merged
merged 4 commits into from
Oct 8, 2023
Merged

Conversation

ManishMadan2882
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Adding a button as the provided design
  • Why was this change needed? (You can also link to an open issue here)
    Its an expected feature from applications generating huge text responses

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 9:36pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 9:36pm

@vercel
Copy link

vercel bot commented Oct 8, 2023

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #503 (3197c35) into main (66fd402) will not change coverage.
Report is 38 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   17.50%   17.50%           
=======================================
  Files          59       59           
  Lines        2719     2719           
=======================================
  Hits          476      476           
  Misses       2243     2243           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dartpain
Copy link
Contributor

dartpain commented Oct 8, 2023

Hi, looks like its too close, Thank you!
Screenshot 2023-10-08 at 01 13 41

@dartpain dartpain linked an issue Oct 8, 2023 that may be closed by this pull request
1 task
@ManishMadan2882
Copy link
Collaborator Author

@dartpain Hey, I have made some corrections after your feedback.

@tenokami
Copy link
Collaborator

tenokami commented Oct 8, 2023

@ManishMadan2882

  1. The distance between all icons should be the same. Currently the space between copy and like is bigger
  2. The icon for copy doesn't look like in figma.
  3. After it's clicked it should change to a checkmark like in figma
  4. Hover doesn't work like indicated in figma

@ManishMadan2882
Copy link
Collaborator Author

ManishMadan2882 commented Oct 8, 2023

I have made the changes @tenokami, added the margin evenly, added the checkmark.
image
On Click
image

@dartpain
Copy link
Contributor

dartpain commented Oct 8, 2023

@holopin-bot @ManishMadan2882 Thank you!

@holopin-bot
Copy link

holopin-bot bot commented Oct 8, 2023

Congratulations @ManishMadan2882, you just earned a badge! Here it is: https://holopin.io/claim/clnhzlu5y06060fkv7hb06bdo

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain dartpain merged commit 8600308 into arc53:main Oct 8, 2023
9 checks passed
@dartpain dartpain mentioned this pull request Oct 8, 2023
1 task
@ManishMadan2882
Copy link
Collaborator Author

Thankyou @dartpain

@tenokami
Copy link
Collaborator

tenokami commented Oct 8, 2023

Great job!

@ManishMadan2882
Copy link
Collaborator Author

Thankyou @tenokami

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: A copy button is needed for the bot response
3 participants