Skip to content

Commit

Permalink
[Sample YAML] Bump ray version in pod security YAML to 2.4.0 (ray-pro…
Browse files Browse the repository at this point in the history
…ject#1160)

The existing sample YAML was pinned to Ray 2.2.0. Running the test locally failed with

2023-06-12:14:21:56,768 INFO     [utils.py:163] Execute command: kubectl logs -n=pod-security -l ray.io/node-type=head --tail=-1
Error from server (BadRequest): container "ray-head" in pod "raycluster-pod-security-head-hg67c" is waiting to start: ContainerCreating
ERROR

======================================================================
ERROR: test_ray_cluster_with_security_context (__main__.PodSecurityTestCase)
Create a RayCluster with securityContext config under restricted mode.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/test_security.py", line 98, in test_ray_cluster_with_security_context
    ray_cluster_add_event.trigger()
  File "/Users/archit/kuberay/tests/framework/prototype.py", line 165, in trigger
    self.wait()
  File "/Users/archit/kuberay/tests/framework/prototype.py", line 277, in wait
    show_cluster_info(self.namespace)
  File "/Users/archit/kuberay/tests/framework/prototype.py", line 90, in show_cluster_info
    shell_subprocess_run(f'kubectl logs -n={cr_namespace} -l ray.io/node-type=head --tail=-1')
  File "/Users/archit/kuberay/tests/framework/utils.py", line 164, in shell_subprocess_run
    return subprocess.run(command, shell = True, check = check).returncode
  File "/Users/archit/anaconda3/envs/ray-py38/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'kubectl logs -n=pod-security -l ray.io/node-type=head --tail=-1' returned non-zero exit status 1.

----------------------------------------------------------------------
Ran 2 tests in 1189.059s

FAILED (errors=1)
It's possible this is just a race condition in the test, but it should be updated to Ray 2.4.0 regardless. I tested it locally with Ray 2.4.0 and it passes.

----------------------------------------------------------------------
Ran 2 tests in 900.921s

OK
This PR will also be cherry-picked to the 0.5.2 release branch.

Signed-off-by: Archit Kulkarni <[email protected]>
  • Loading branch information
architkulkarni committed Jun 12, 2023
1 parent e430a93 commit 110216f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ray-operator/config/security/ray-cluster.pod-security.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
# A unique identifier for the head node and workers of this cluster.
name: raycluster-pod-security
spec:
rayVersion: '2.2.0'
rayVersion: '2.4.0'
# Ray head pod configuration
headGroupSpec:
# for the head group, replicas should always be 1.
Expand All @@ -24,7 +24,7 @@ spec:
spec:
containers:
- name: ray-head
image: rayproject/ray-ml:2.2.0
image: rayproject/ray-ml:2.4.0
ports:
- containerPort: 6379
name: gcs
Expand Down Expand Up @@ -88,7 +88,7 @@ spec:
spec:
containers:
- name: ray-worker
image: rayproject/ray-ml:2.2.0
image: rayproject/ray-ml:2.4.0
# environment variables to set in the container.Optional.
# Refer to https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/
lifecycle:
Expand Down

0 comments on commit 110216f

Please sign in to comment.