Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support keywords meta tag #29

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Add support keywords meta tag #29

merged 3 commits into from
Apr 24, 2023

Conversation

datlechin
Copy link
Contributor

Hi, this PR is add support for keywords tag.

  • Add support for keywords meta tag
  • Fix command return value from Command::SUCCESS to self::SUCCESS and Command::FAILURE to self::FAILURE.
  • Fix the typo enabled in twitter method argument.
  • Change the path of the views directory from assets/views to views.

@stancl
Copy link
Member

stancl commented Apr 23, 2023

Thanks for the PR!

What's the reasoning for moving the views directory?

@datlechin
Copy link
Contributor Author

datlechin commented Apr 23, 2023 •
edited
Loading

@stancl views it should be located in resources folder (same as other laravel packages)

@stancl
Copy link
Member

stancl commented Apr 24, 2023

I see, moving them to resources/ makes sense 👍🏻

@stancl stancl merged commit 567a7b0 into archtechx:master Apr 24, 2023
@stancl stancl mentioned this pull request Apr 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datlechin @stancl