Show wallet creation error when key length mismatched #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7i7o
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Can we change the messaging?
- Import/Add wallet from JWK: Error message 👍
- Creating/Importing wallet from a seedphrase:
- automatically retry
- maybe show a message that it's taking longer than usual
Whenever we create the key (from a seedphrase), it should always be valid.
Whenever a key comes from the user, then we should show an error for bad keys.
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR shows the wallet generation error modal when actual key length doesn't equals to expected key length with retry action key to retry wallet generation. Also, it fixes the password matching logic.
How To Test
ArConnect/src/wallets/generator.ts
Line 27 in dc1d616
modulusLength: [4096, 2048][Math.floor(Math.random() * 2)]to test this PR so that the error modal shows.