Add statusline uniform background color configuration #58

dylnmc · 2017-09-26T01:09:52Z

Fixes #37

configure statusline with

let g:nord_statusline_uniform = 1

default is to use brighter background (0), but easily configurable
with by setting g:nord_statusline_uniform to 1)

NOTE: this does not work with airline or lightline

configure statusline with ```vim let g:nord_statusline_uniform = 1 ``` default is to use brighter background (`0`), but easily configurable with by setting `g:nord_statusline_uniform` to `1`) NOTE: this does not work with airline or lightline

arcticicestudio

Thanks for this awesome contribution ✨

I've added some review improvement suggestions. The merge conflict can be resolved via a rebase on the develop branch.

Checkout into the branch and run

git checkout develop
git fetch --all --prune
git pull --ff-only --prune
git rebase develop

This will apply the latest develop branch commits to your branch and places your changes on top of it (HEAD).

dylnmc · 2017-09-30T02:20:42Z

... looks like I did it (though I had to use git rebase upstream/develop) ... I also changed a p tag in readme .. well, you forgot p tag (search for <align on the readme on develop branch 😄)

The variable has been renamed to "nord_uniform_status_lines" to better match the name scheme. The documentation style has been updated and preview screenshots have been added. GH-37

arcticicestudio

Alright, there was some commit chaos so I've fixed- and forced pushed it to your branch.
Everything is now fine, I'll merge it this evening.

Thanks again for this config ;)

arcticicestudio · 2017-09-28T04:19:41Z

README.md

+
+By default, Nord uses a slightly brighter background for the current split buffer.
+This is designed to draw attention to the currently active buffer without being
+distracting.


I haven't got the time to add the community guidelines to this project, but it uses a line length of 160 so this can go one line up 😄

arcticicestudio · 2017-09-28T04:20:22Z

README.md

+distracting.
+
+However, if the user desires the backgrounds to be a uniform color,
+`g:nord_statusline_uniform` can be set to `1` as follows:


Same here for the line length. Also please add a blank line between the code block and the text.

arcticicestudio · 2017-09-28T04:20:53Z

colors/nord.vim

@@ -52,6 +52,10 @@ if !exists('g:nord_italic_comments')
  let g:nord_italic_comments = 0
 endif

+if !exists('g:nord_statusline_uniform')
+    let g:nord_statusline_uniform = 0


I haven't got the time to add the community guidelines to this project, but it uses a indentation of 2 spaces (no tabs) 😄
Please also fix it for the rest of this PR.

The implemented feature in this GH-58 changed the background color of the status bar ("StatusLine") group to "nord3", but the "WildMenu" group also useed "nord3" as background color for the current tab selection. This commit changes the "WildMenu" background color to "nord1" which is available for both terminal ("nord1_term") and GUI ("nord1_gui") mode. Related to GH-58 GH-64

This commit fixes the middle element of inactive bars for the "nord" theme caused by nordtheme/vim#58. Related to nordtheme/vim#73

…169) The included theme bundles have not supported the "uniform status line" feature (GH-58), which allows to change the background color of the status bar (StatusLine) group to `nord3`. Related to GH-58 Resolves GH-168

* adds coc error gutter support * remove duplicated entries * Update colors/nord.vim Co-Authored-By: Arctic Ice Studio <[email protected]> * Fix typo line 13 * Uniform status lines config for bundled airline and lightline themes (nordtheme#169) The included theme bundles have not supported the "uniform status line" feature (nordthemeGH-58), which allows to change the background color of the status bar (StatusLine) group to `nord3`. Related to nordthemeGH-58 Resolves nordthemeGH-168 * Plugin support for `vim-startify` (nordtheme#176) Added custom highlight groups of the `vim-startify` (1) plugin to adapt to Nord's style. References: (1) https://github.com/mhinz/vim-startify Resolves nordthemeGH-159 * Remove underline from gutter line numbers (nordtheme#185) Vim version 8.1.2029 [1] added the `underline` attribute for the `CursorLineNr` group to `cterm` [2] based on vim/vim#4933 [3]. This change resulted in gutter line numbers being underlined which has now been reverted back to Nord's style by explicitly setting the attribute for the group to `NONE`. [1]: https://github.com/vim/vim/releases/tag/v8.1.2029 [2]: vim/vim@d9b0d83...017ba07#diff-80fffb3e9c20e93e5b2328a9a20e19c9 [3]: vim/vim#4933 Resolves nordthemeGH-174 * Prepare release version 0.13.0 * adds coc error gutter support * Add nvim-lsp support (nordtheme#198) Added highlighting support for the build-in Neovim language server [1] using the coc.nvim [2] groups as reference. [1]: https://github.com/neovim/nvim-lsp [2]: https://github.com/neoclide/coc.nvim * Consistent `Error` and MoreMsg highlight group consistent between console and GUI modes. (nordtheme#202) Consistent `Error` and `MoreMsg` highligh. in term and GUI mode (nordtheme#202) Before the `Error` group in GUI mode used `nord0` as foreground color instead of `nord4` resulting in a bad contrast. Also after checking ( links to it) Also since there was also no color defined for terminal mode for the `MoreMsg` group (see `:help MoreMsg` that link to `:help more-prompt`) Vim used the default color which was some kind of green. To ensure it matches Nord's style it has now been changed to use `nord8` (main accent color) for both terminal and GUI mode. This can be tested by running `:echon "MESSAGE\n"` taht produces a lot of lines that won't fit on the current screen space anymore. Co-authored-by: Arctic Ice Studio <[email protected]> Co-authored-by: Sven Greb <[email protected]> * Use transparent background for gutter line number in GUI mode (nordtheme#204) The `LineNr` and `CursorLineNr` highlight groups now have a transparent background in GUI mode. Before it was set to `nord0_gui` which worked fine in most cases. However, some plugins use these highlight groups to render their content in a popup window which can potentially have a different background color. This caused some issues e.g. for the fuzzy search plugin LeaderF [1]. The compatibility with the `g:nord_cursor_line_number_background` theme configuration has been verified to work as expected in both modes when it is set to `0` or `1`. This change is not related to the terminal mode or when using `set notermguicolors` since `ctermbg` for `LineNr` and `CursorLineNr` is set to `NONE` by default. [1]: https://github.com/Yggdroot/LeaderF * Release version 0.14.0 * adds coc error gutter support * Add nvim-lsp support (nordtheme#198) Added highlighting support for the build-in Neovim language server [1] using the coc.nvim [2] groups as reference. [1]: https://github.com/neovim/nvim-lsp [2]: https://github.com/neoclide/coc.nvim * Add basic TypeScript and improve TSX support (nordtheme#208) Basic highlighting support for TypeScript & TSX Added basic support to highlight TypeScript & TSX syntax more consistently through the HerringtonDarkholme/yats.vim plugin [1]. This includes improvements to highlight... 1. ...TypeScript interface an class names using `nord7` as foreground, where interfaces also use the bold attribute, to match with structs/classes. 2. ...global methods like e.g. `setTimeout` with `nord8` using the italic attribute to mark it kind of static. 3. ...regular expressions with `nord13` as foreground color instead of the normal color for quoted strings (`nord14`) to make it easier to differ between both. 4. ...global objects like `Error`, `JSON` and `console` with `nord7`. 5. ...primitive/builtin types like `string` with `nord9`. 6. ...TypeScript type references with `nord7`. 7. ...TypeScript specific characters like for type annotations (`:`) and member optionality (`?`) as operator with `nord9`. This also includes improvements for "vanilla" JavaScript elements. [1]: https://github.com/HerringtonDarkholme/yats.vim Resolves nordthemeGH-208 Co-authored-by: Arctic Ice Studio <[email protected]> Co-authored-by: Sven Greb <[email protected]> * Add support for vim-clap (nordtheme#178) Added basic support for vim-clap [1], a modern and performant generic finder and dispatcher for Vim and NeoVim. [1]: https://github.com/liuchengxu/vim-clap nordthemeGH-178 Co-authored-by: Arctic Ice Studio <[email protected]> Co-authored-by: Sven Greb <[email protected]> * Release version 0.15.0 Co-authored-by: Arctic Ice Studio <[email protected]> Co-authored-by: john.hennessey <[email protected]> Co-authored-by: John Hennessey <[email protected]> Co-authored-by: Radu Vasilescu <[email protected]> Co-authored-by: Jose M. Murinello <[email protected]> Co-authored-by: Alexander Jeurissen <[email protected]> Co-authored-by: xulongwu4 <[email protected]> Co-authored-by: Sven Greb <[email protected]> Co-authored-by: iamdi <[email protected]> Co-authored-by: Johan <[email protected]>

arcticicestudio requested changes Sep 28, 2017

View reviewed changes

arcticicestudio assigned arcticicestudio and dylnmc and unassigned arcticicestudio Sep 28, 2017

arcticicestudio changed the title ~~fixes #37 and provides statusline configuration~~ Add statusline uniform background color configuration Sep 28, 2017

arcticicestudio added context-config type-feature context-ui labels Sep 28, 2017

arcticicestudio added this to the 0.7.0 milestone Sep 28, 2017

arcticicestudio mentioned this pull request Sep 28, 2017

improve status line visibility #46

Closed

dylnmc closed this Sep 30, 2017

dylnmc reopened this Sep 30, 2017

arcticicestudio added 2 commits October 1, 2017 10:04

Optimize uniform status lines theme config

30f0e1b

The variable has been renamed to "nord_uniform_status_lines" to better match the name scheme. The documentation style has been updated and preview screenshots have been added. GH-37

Merge branch 'develop' into fix-statusline

f62b96a

arcticicestudio approved these changes Oct 1, 2017

View reviewed changes

arcticicestudio merged commit 9305680 into nordtheme:develop Oct 1, 2017

arcticicestudio mentioned this pull request Oct 24, 2017

vim tab completion highlight #64

Closed

arcticicestudio mentioned this pull request Nov 19, 2017

fixes invisible inactive lightline bar #73

Merged

This was referenced Dec 5, 2017

Fix "WildMenu" background color for current selection (tab completion) #80

Merged

Fix invisible inactive bar for "nord" color scheme itchyny/lightline.vim#270

Merged

arcticicestudio unassigned dylnmc Dec 28, 2017

YCbCr pushed a commit to YCbCr/lightline.vim that referenced this pull request May 26, 2019

Fix invisible inactive bar for "nord" color scheme

c287402

This commit fixes the middle element of inactive bars for the "nord" theme caused by nordtheme/vim#58. Related to nordtheme/vim#73

muriware mentioned this pull request Jul 14, 2019

Update airline and lightline theme bundles to use uniform background color configuration #169

Merged

svengreb added the scope-compatibility label Feb 12, 2022

svengreb added scope-ux and removed scope-compatibility labels Feb 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add statusline uniform background color configuration #58

Add statusline uniform background color configuration #58

dylnmc commented Sep 26, 2017 •

edited by arcticicestudio

Loading

arcticicestudio left a comment

dylnmc commented Sep 30, 2017 •

edited

Loading

arcticicestudio left a comment

arcticicestudio Sep 28, 2017

arcticicestudio Sep 28, 2017

arcticicestudio Sep 28, 2017

Add statusline uniform background color configuration #58

Add statusline uniform background color configuration #58

Conversation

dylnmc commented Sep 26, 2017 • edited by arcticicestudio Loading

arcticicestudio left a comment

Choose a reason for hiding this comment

dylnmc commented Sep 30, 2017 • edited Loading

arcticicestudio left a comment

Choose a reason for hiding this comment

arcticicestudio Sep 28, 2017

Choose a reason for hiding this comment

arcticicestudio Sep 28, 2017

Choose a reason for hiding this comment

arcticicestudio Sep 28, 2017

Choose a reason for hiding this comment

dylnmc commented Sep 26, 2017 •

edited by arcticicestudio

Loading

dylnmc commented Sep 30, 2017 •

edited

Loading