Created async overload for clausules that use a predicate #228
Conversation
|
I made GetCustomStruct public. There was a build error for this. |
There was a problem hiding this comment.
Great job @danny-bos-developer for creating easy to read, and succinct unit tests. This could be a great fail early scenario generally speaking.
Small suggestion... I would rename the method to be called ExpressionAsync instead of AgainstExpressionAsync since this is extending off the IGuardClause of this library, and the only entry point to this method is via the Against property so it is already explicit via usage of the library.
Great addition! Cheers.
|
@Reapism Thanks Antony and I agree with your suggestion to remove Guard from the method. I only cannot edit any files in my PR. Some assistance or guidance would be appreciated. |
|
I need some TLC for this PR please |
|
@danny-bos-developer are you not able to edit the pull request? |
|
I'll get it sorted |
|
Alright, thank you. You probably need to remerge with the master again too because JetBrains has been removed.
Kind regards
Danny
From: Steve Smith ***@***.***>
Sent: Thursday, February 16, 2023 3:12 PM
To: ardalis/GuardClauses ***@***.***>
Cc: Bos, Danny ***@***.***>; Comment ***@***.***>
Subject: Re: [ardalis/GuardClauses] Created async overload for clausules that use a predicate (PR #228)
External email
I'll get it sorted
—
Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fardalis%2FGuardClauses%2Fpull%2F228%23issuecomment-1433150046&data=05%7C01%7Cdanny.bos%40tatasteeleurope.com%7C271a3c02565943b6816908db1027c717%7C44bbd632fe0442d7933e2649dcd22649%7C0%7C0%7C638121535253189682%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=L5woDxhcpWRBkoYf%2BZfKElFgSIjlNtAvGvyDr%2BcD%2B78%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJQYIVR5LOM2DLHFQ2ZHJJ3WXYYTFANCNFSM6AAAAAAQQ4PFUU&data=05%7C01%7Cdanny.bos%40tatasteeleurope.com%7C271a3c02565943b6816908db1027c717%7C44bbd632fe0442d7933e2649dcd22649%7C0%7C0%7C638121535253189682%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gl1vidUk51i0%2FRVsSJ3q3bSSPpdhKFEapXX0Kh4C8jI%3D&reserved=0>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
**********************************************************************
This transmission is confidential and must not be used or disclosed by anyone other than the intended recipient. Neither Tata Steel Europe Limited nor any of its subsidiaries can accept any responsibility for any use or misuse of the transmission by anyone.
For address and company registration details of certain entities within the Tata Steel Europe group of companies, please visit https://www.tatasteeleurope.com/en/legal-notice/entities
**********************************************************************
Sensitivity: general
|
|
Temporarily breaking main with this... |
PR regarding dicussion 226:
#226
I've created the async overloads and UnitTests for it.