Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CriticalError to ResultStatuses (#140) #141

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

EnochMtzR
Copy link
Contributor

This is my take on adding the Critical Error status

@EnochMtzR EnochMtzR mentioned this pull request Jun 16, 2023
@EnochMtzR EnochMtzR linked an issue Jun 18, 2023 that may be closed by this pull request
@ardalis
Copy link
Owner

ardalis commented Jun 28, 2023

Can you update the tests?

@ardalis
Copy link
Owner

ardalis commented Sep 12, 2023

Hmm CI build is still failing even though it says tests passed and no errors. I'll merge it and see if there's anything I need to fix. Thanks!

@ardalis ardalis merged commit 8e93188 into ardalis:main Sep 12, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical ErrorResult
2 participants