Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json-schema): restore support for explode: true with strings #4678

Merged
merged 1 commit into from
Oct 17, 2022
Merged

fix(json-schema): restore support for explode: true with strings #4678

merged 1 commit into from
Oct 17, 2022

Conversation

mhassan1
Copy link
Contributor

Description

This PR fixes a regression in the query string logic in the json-schema loader so that explode: true in the openapi loader works properly for type: string parameters.

Fixes #4677.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

This PR updates explode.test.ts to include new test cases for object and string parameters.

See #4677 for reproduction steps.

Test Environment:

  • OS: MacOS
  • @graphql-mesh/openapi: ^0.33.26
  • NodeJS: 16.17.1

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

🦋 Changeset detected

Latest commit: 7d9d414

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@omnigraph/json-schema Patch
@graphql-mesh/json-schema Patch
@omnigraph/openapi Patch
@omnigraph/raml Patch
@graphql-mesh/container Patch
auth0-example Patch
cloudflare-workers Patch
hasura-openbrewery-geodb Patch
hello-world-esm Patch
json-schema-hello-world Patch
covid-mesh Patch
json-schema-example Patch
json-schema-fhir Patch
json-schema-subscriptions Patch
reddit-example Patch
@graphql-mesh/openapi Patch
@graphql-mesh/raml Patch
nextjs-apollo-example Patch
nextjs-sdk-example Patch
javascript-wiki Patch
typescript-location-weather-example Patch
openapi-stackexchange Patch
openapi-stripe Patch
openapi-subscriptions Patch
openapi-youtrack Patch
programmatic-batching-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theguild-bot theguild-bot mentioned this pull request Oct 13, 2022
@ardatan ardatan merged commit 56f852b into ardatan:master Oct 17, 2022
@mhassan1 mhassan1 deleted the explode-string branch October 19, 2022 02:35
@theguild-bot theguild-bot mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

string parameters excluded with explode: true
2 participants