Skip to content

Commit

Permalink
Type fixes for TypeScript 4.8 (#4673)
Browse files Browse the repository at this point in the history
* Rerun prettier

* Fix typings for TypeScript 4.8
  • Loading branch information
thgreasi authored Aug 26, 2022
1 parent 04f3c27 commit 4fe3d9c
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
"@graphql-tools/apollo-engine-loader": patch
'@graphql-tools/apollo-engine-loader': patch
---

dependencies updates:
dependencies updates:

- Updated dependency [`@whatwg-node/fetch@^0.3.0` ↗︎](https://www.npmjs.com/package/@whatwg-node/fetch/v/null) (from `^0.2.9`, in `dependencies`)
4 changes: 2 additions & 2 deletions .changeset/@graphql-tools_github-loader-4665-dependencies.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
"@graphql-tools/github-loader": patch
'@graphql-tools/github-loader': patch
---

dependencies updates:
dependencies updates:

- Updated dependency [`@whatwg-node/fetch@^0.3.0` ↗︎](https://www.npmjs.com/package/@whatwg-node/fetch/v/null) (from `^0.2.9`, in `dependencies`)
4 changes: 2 additions & 2 deletions .changeset/@graphql-tools_jest-transform-4671-dependencies.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
"@graphql-tools/jest-transform": patch
'@graphql-tools/jest-transform': patch
---

dependencies updates:
dependencies updates:

- Updated dependency [`@jest/transform@^29.0.0` ↗︎](https://www.npmjs.com/package/@jest/transform/v/null) (from `^28.0.0`, in `dependencies`)
- Updated dependency [`@jest/types@^29.0.0` ↗︎](https://www.npmjs.com/package/@jest/types/v/null) (from `^28.0.0`, in `dependencies`)
4 changes: 2 additions & 2 deletions .changeset/@graphql-tools_url-loader-4665-dependencies.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
"@graphql-tools/url-loader": patch
'@graphql-tools/url-loader': patch
---

dependencies updates:
dependencies updates:

- Updated dependency [`@whatwg-node/fetch@^0.3.0` ↗︎](https://www.npmjs.com/package/@whatwg-node/fetch/v/null) (from `^0.2.9`, in `dependencies`)
6 changes: 6 additions & 0 deletions .changeset/nasty-owls-compare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@graphql-tools/utils': patch
'@graphql-tools/wrap': patch
---

Fix typings for TypeScript 4.8
2 changes: 1 addition & 1 deletion packages/utils/src/Interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import {
// graphql-js < v15 backwards compatible ExecutionResult
// See: https://github.com/graphql/graphql-js/pull/2490

export type ExecutionResult<TData = Record<string, any>> = GraphQLExecutionResult & {
export type ExecutionResult<TData = Record<string, any>> = GraphQLExecutionResult<TData> & {
data?: TData | null;
extensions?: Record<string, any>;
};
Expand Down
2 changes: 1 addition & 1 deletion packages/wrap/src/transforms/HoistField.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import MapFields from './MapFields.js';

interface HoistFieldTransformationContext extends Record<string, any> {}

export default class HoistField<TContext = Record<string, any>>
export default class HoistField<TContext extends Record<string, any> = Record<string, any>>
implements Transform<HoistFieldTransformationContext, TContext>
{
private readonly typeName: string;
Expand Down

1 comment on commit 4fe3d9c

@vercel
Copy link

@vercel vercel bot commented on 4fe3d9c Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.