fix(utils/createGraphQLError): Convert GraphQLError like originalErro…

…r property to a GraphQLError
ardatan · Oct 10, 2023 · b4c1759 · b4c1759
1 parent 0e87254
commit b4c1759
Show file tree

Hide file tree

Showing 3 changed files with 55 additions and 0 deletions.
diff --git a/.changeset/chilly-scissors-wave.md b/.changeset/chilly-scissors-wave.md
@@ -0,0 +1,5 @@
+---
+'@graphql-tools/utils': patch
+---
+
+Convert GraphQLError like originalError property to a GraphQLError
diff --git a/packages/utils/src/errors.ts b/packages/utils/src/errors.ts
@@ -14,7 +14,38 @@ interface GraphQLErrorOptions {
   extensions?: any;
 }
 
+const possibleGraphQLErrorProperties = [
+  'message',
+  'locations',
+  'path',
+  'nodes',
+  'source',
+  'positions',
+  'originalError',
+  'name',
+  'stack',
+  'extensions',
+];
+
+function isGraphQLErrorLike(error: any) {
+  return (
+    error != null &&
+    typeof error === 'object' &&
+    Object.keys(error).every(key => possibleGraphQLErrorProperties.includes(key))
+  );
+}
+
 export function createGraphQLError(message: string, options?: GraphQLErrorOptions): GraphQLError {
+  if (
+    options?.originalError &&
+    !(options.originalError instanceof Error) &&
+    isGraphQLErrorLike(options.originalError)
+  ) {
+    options.originalError = createGraphQLError(
+      (options.originalError as any).message,
+      options.originalError,
+    );
+  }
   if (versionInfo.major >= 17) {
     return new (GraphQLError as any)(message, options);
   }

diff --git a/packages/utils/tests/createGraphQLError.test.ts b/packages/utils/tests/createGraphQLError.test.ts
@@ -0,0 +1,19 @@
+import { GraphQLError } from 'graphql';
+import { createGraphQLError } from '../src/errors';
+
+it('should handle non Error originalError', () => {
+  const error = createGraphQLError('message', {
+    originalError: {
+      message: 'originalError',
+      extensions: { code: 'ORIGINAL_ERROR' },
+    } as any,
+  });
+  expect(error.originalError).toBeInstanceOf(GraphQLError);
+  expect(error).toMatchObject({
+    message: 'message',
+    originalError: {
+      message: 'originalError',
+      extensions: { code: 'ORIGINAL_ERROR' },
+    },
+  });
+});