fix: typescript commonjs module resolution with node16,nodenext (#4624)

* fix: typescript commonjs resolution * fix: bob paths * upgrade bob * use stable bob version * Update .changeset/fluffy-pianos-know.md
ardatan · Aug 5, 2022 · e3167ed · e3167ed
1 parent a56082b
commit e3167ed
Show file tree

Hide file tree

Showing 35 changed files with 109 additions and 74 deletions.
diff --git a/.changeset/fluffy-pianos-know.md b/.changeset/fluffy-pianos-know.md
@@ -0,0 +1,36 @@
+---
+'@graphql-tools/batch-delegate': patch
+'@graphql-tools/batch-execute': patch
+'@graphql-tools/delegate': patch
+'@graphql-tools/graphql-tag-pluck': patch
+'graphql-tools': patch
+'@graphql-tools/import': patch
+'@graphql-tools/jest-transform': patch
+'@graphql-tools/links': patch
+'@graphql-tools/load': patch
+'@graphql-tools/load-files': patch
+'@graphql-tools/apollo-engine-loader': patch
+'@graphql-tools/code-file-loader': patch
+'@graphql-tools/git-loader': patch
+'@graphql-tools/github-loader': patch
+'@graphql-tools/graphql-file-loader': patch
+'@graphql-tools/json-file-loader': patch
+'@graphql-tools/module-loader': patch
+'@graphql-tools/prisma-loader': patch
+'@graphql-tools/url-loader': patch
+'@graphql-tools/merge': patch
+'@graphql-tools/mock': patch
+'@graphql-tools/node-require': patch
+'@graphql-tools/optimize': patch
+'@graphql-tools/relay-operation-optimizer': patch
+'@graphql-tools/resolvers-composition': patch
+'@graphql-tools/schema': patch
+'@graphql-tools/stitch': patch
+'@graphql-tools/stitching-directives': patch
+'@graphql-tools/utils': patch
+'@graphql-tools/webpack-loader': patch
+'@graphql-tools/webpack-loader-runtime': patch
+'@graphql-tools/wrap': patch
+---
+
+Fix CommonJS TypeScript resolution with `moduleResolution` `node16` or `nodenext`
diff --git a/package.json b/package.json
@@ -49,7 +49,7 @@
     "@typescript-eslint/eslint-plugin": "5.32.0",
     "@typescript-eslint/parser": "5.32.0",
     "babel-jest": "28.1.3",
-    "bob-the-bundler": "2.0.0",
+    "bob-the-bundler": "4.0.0",
     "chalk": "4.1.2",
     "concurrently": "7.3.0",
     "eslint": "8.21.0",
@@ -83,10 +83,10 @@
     ]
   },
   "workspaces": [
-    "./packages/*",
-    "./packages/loaders/*",
-    "./website",
-    "./benchmark/*"
+    "packages/*",
+    "packages/loaders/*",
+    "website",
+    "benchmark/*"
   ],
   "resolutions": {
     "graphql": "16.5.0",

diff --git a/packages/batch-delegate/package.json b/packages/batch-delegate/package.json
@@ -14,7 +14,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -28,7 +28,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/batch-execute/package.json b/packages/batch-execute/package.json
@@ -14,7 +14,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -28,7 +28,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/delegate/package.json b/packages/delegate/package.json
@@ -14,7 +14,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -28,7 +28,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/graphql-tag-pluck/package.json b/packages/graphql-tag-pluck/package.json
@@ -14,7 +14,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -28,7 +28,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/graphql-tools/package.json b/packages/graphql-tools/package.json
@@ -14,7 +14,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -28,7 +28,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/import/package.json b/packages/import/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/jest-transform/package.json b/packages/jest-transform/package.json
@@ -14,7 +14,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -28,7 +28,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/links/package.json b/packages/links/package.json
@@ -14,7 +14,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -28,7 +28,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/load-files/package.json b/packages/load-files/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/load/package.json b/packages/load/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/loaders/apollo-engine/package.json b/packages/loaders/apollo-engine/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/loaders/code-file/package.json b/packages/loaders/code-file/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/loaders/git/package.json b/packages/loaders/git/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/loaders/github/package.json b/packages/loaders/github/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/loaders/graphql-file/package.json b/packages/loaders/graphql-file/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/loaders/json-file/package.json b/packages/loaders/json-file/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/loaders/module/package.json b/packages/loaders/module/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {

diff --git a/packages/loaders/prisma/package.json b/packages/loaders/prisma/package.json
@@ -15,7 +15,7 @@
   "exports": {
     ".": {
       "require": {
-        "types": "./dist/typings/index.d.ts",
+        "types": "./dist/typings/index.d.cts",
         "default": "./dist/cjs/index.js"
       },
       "import": {
@@ -29,7 +29,7 @@
     },
     "./*": {
       "require": {
-        "types": "./dist/typings/*.d.ts",
+        "types": "./dist/typings/*.d.cts",
         "default": "./dist/cjs/*.js"
       },
       "import": {