Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing test for missing object prototype (#127) #128

Closed
wants to merge 1 commit into from

Conversation

patotoma
Copy link

@patotoma patotoma commented Sep 7, 2016

@apollo-cla
Copy link

@patotoma: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@sebastienbarre
Copy link
Contributor

Thanks @patotoma

@DxCx
Copy link
Contributor

DxCx commented Sep 8, 2016

Hi @patotoma, i want to make sure i got it right, you expect that getPrototypeOf thread should be an "Object" right?

@patotoma
Copy link
Author

patotoma commented Sep 8, 2016

Hey @DxCx ! Yes, object should have an object prototype.
Look issue #127 for more details.

@sebastienbarre
Copy link
Contributor

@patotoma So am I to understand from #127 that this is likely not in graphql-tools?

@DxCx
Copy link
Contributor

DxCx commented Sep 9, 2016

@sebastienbarre, thats correct.
Object construction comes from graphql-js.
We need to open a new bug foe graphql-js.

@DxCx
Copy link
Contributor

DxCx commented Sep 13, 2016

seem to be graphql-js issue, have a pending issue there.

@DxCx DxCx closed this Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants