Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stitching): ensure transformSchema called only once #4648

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Aug 11, 2022

Fixes #4631

After the refactor done in #4566, transforms are called twice.
This removes that call, too.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022

🦋 Changeset detected

Latest commit: c1bb9e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@graphql-tools/delegate Patch
@graphql-tools/stitch Patch
@graphql-tools/wrap Patch
@graphql-tools/batch-delegate Patch
@graphql-tools/links Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/url-loader Patch
federation-benchmark Patch
@graphql-tools/prisma-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-tools ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 3:32PM (UTC)

@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 8.3.4-alpha-20220811153013-214a7a19 npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 9.0.2-alpha-20220811153013-214a7a19 npm ↗︎ unpkg ↗︎
@graphql-tools/links 8.3.4-alpha-20220811153013-214a7a19 npm ↗︎ unpkg ↗︎
@graphql-tools/prisma-loader 7.2.11-alpha-20220811153013-214a7a19 npm ↗︎ unpkg ↗︎
@graphql-tools/url-loader 7.13.6-alpha-20220811153013-214a7a19 npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 8.7.4-alpha-20220811153013-214a7a19 npm ↗︎ unpkg ↗︎
@graphql-tools/stitching-directives 2.3.4-alpha-20220811153013-214a7a19 npm ↗︎ unpkg ↗︎
@graphql-tools/wrap 9.0.2-alpha-20220811153013-214a7a19 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 236      ✗ 0  
     data_received..................: 28 MB   2.7 MB/s
     data_sent......................: 101 kB  10 kB/s
     http_req_blocked...............: avg=6.65µs   min=2.7µs   med=3.6µs   max=262.6µs  p(90)=4.4µs    p(95)=4.63µs  
     http_req_connecting............: avg=1.78µs   min=0s      med=0s      max=211.1µs  p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=79.32ms  min=66.66ms med=74.95ms max=177.91ms p(90)=82.95ms  p(95)=126.21ms
       { expected_response:true }...: avg=79.32ms  min=66.66ms med=74.95ms max=177.91ms p(90)=82.95ms  p(95)=126.21ms
     http_req_failed................: 0.00%   ✓ 0        ✗ 118
     http_req_receiving.............: avg=171.57µs min=142µs   med=161.3µs max=870.41µs p(90)=178.39µs p(95)=183.04µs
     http_req_sending...............: avg=95.27µs  min=18.3µs  med=27.15µs max=3.44ms   p(90)=32.86µs  p(95)=410.19µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=79.05ms  min=66.47ms med=74.77ms max=176.98ms p(90)=82.3ms   p(95)=126.02ms
     http_reqs......................: 118     11.77457/s
     iteration_duration.............: avg=84.9ms   min=72.36ms med=80.13ms max=183.14ms p(90)=92.11ms  p(95)=131.22ms
     iterations.....................: 118     11.77457/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

@ardatan ardatan merged commit 29ee754 into master Aug 11, 2022
@ardatan ardatan deleted the fix-transform-call branch August 11, 2022 15:33
@Urigo
Copy link
Collaborator

Urigo commented Aug 11, 2022

/theguild newsletter

@pixeldrew
Copy link

When will 8.7.4 be released? right now I only see alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants