Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unmerged fields #6134

Merged
merged 5 commits into from
May 7, 2024
Merged

Ignore unmerged fields #6134

merged 5 commits into from
May 7, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented May 3, 2024

If a field is not going to be used for type merging in the following calls, do not add it to the final query to the subgraph.

See the changeset for the example

Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: 4bf7835

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-tools/delegate Patch
@graphql-tools/stitch Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 3, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 340      ✗ 0  
     data_received..................: 40 MB   3.9 MB/s
     data_sent......................: 146 kB  15 kB/s
     http_req_blocked...............: avg=3.97µs   min=2.09µs   med=2.63µs   max=173.61µs p(90)=3.74µs   p(95)=4.01µs 
     http_req_connecting............: avg=688ns    min=0s       med=0s       max=117.04µs p(90)=0s       p(95)=0s     
     http_req_duration..............: avg=54.73ms  min=45.85ms  med=51.04ms  max=156.01ms p(90)=60.68ms  p(95)=86.92ms
       { expected_response:true }...: avg=54.73ms  min=45.85ms  med=51.04ms  max=156.01ms p(90)=60.68ms  p(95)=86.92ms
     http_req_failed................: 0.00%   ✓ 0        ✗ 170
     http_req_receiving.............: avg=133.66µs min=105.23µs med=129.64µs max=297.37µs p(90)=152.31µs p(95)=163.3µs
     http_req_sending...............: avg=25.39µs  min=17.53µs  med=23.72µs  max=63.69µs  p(90)=32.69µs  p(95)=35.56µs
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s     
     http_req_waiting...............: avg=54.57ms  min=45.71ms  med=50.9ms   max=155.66ms p(90)=60.46ms  p(95)=86.77ms
     http_reqs......................: 170     16.97103/s
     iteration_duration.............: avg=58.9ms   min=49.34ms  med=55.05ms  max=159.87ms p(90)=67.26ms  p(95)=90.69ms
     iterations.....................: 170     16.97103/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

Copy link
Contributor

github-actions bot commented May 3, 2024

💻 Website Preview

The latest changes are available as preview in: https://7ec8a639.graphql-tools.pages.dev

Copy link
Contributor

github-actions bot commented May 7, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/delegate 10.0.10-alpha-20240507100550-4bf783541466a6d38269f884d7499da67bcbc345 npm ↗︎ unpkg ↗︎
@graphql-tools/federation 1.1.35-alpha-20240507100550-4bf783541466a6d38269f884d7499da67bcbc345 npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.2.8-alpha-20240507100550-4bf783541466a6d38269f884d7499da67bcbc345 npm ↗︎ unpkg ↗︎

@ardatan ardatan marked this pull request as ready for review May 7, 2024 09:55
@ardatan ardatan merged commit a83da08 into master May 7, 2024
30 checks passed
@ardatan ardatan deleted the ignore-unmerged-fields branch May 7, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants