Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation: Update Tests & Interface Objects 2nd take #6194

Merged
merged 4 commits into from
May 27, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented May 17, 2024

This PR rewrites the implementation for interface objects in Federation.
Instead of handling them as object types, it handles them as interface types as-in defined in the supergraph

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: c3df80d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@graphql-tools/batch-delegate Patch
@graphql-tools/federation Patch
@graphql-tools/delegate Patch
@graphql-tools/schema Patch
@graphql-tools/stitch Patch
@graphql-tools/utils Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan force-pushed the union-intersection-distributed branch from 9ea51d8 to 2d6d466 Compare May 17, 2024 13:59
Base automatically changed from union-intersection-distributed to master May 17, 2024 14:04
@ardatan ardatan force-pushed the interface-objects-2nd-take branch from a6c876e to 967f735 Compare May 20, 2024 14:45
@ardatan ardatan marked this pull request as ready for review May 20, 2024 14:45
@ardatan ardatan force-pushed the interface-objects-2nd-take branch from 967f735 to f39306a Compare May 20, 2024 14:57
@ardatan ardatan force-pushed the interface-objects-2nd-take branch from f39306a to fa5bebf Compare May 20, 2024 14:58
@ardatan ardatan changed the title Interface Objects 2nd take Federation: Update Tests & Interface Objects 2nd take May 20, 2024
Copy link
Contributor

github-actions bot commented May 20, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 9.0.3-alpha-20240524170724-c3df80d8964ba3eddd7324869672e73e2190ad42 npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 10.0.11-alpha-20240524170724-c3df80d8964ba3eddd7324869672e73e2190ad42 npm ↗︎ unpkg ↗︎
@graphql-tools/federation 1.1.36-alpha-20240524170724-c3df80d8964ba3eddd7324869672e73e2190ad42 npm ↗︎ unpkg ↗︎
@graphql-tools/schema 10.0.4-alpha-20240524170724-c3df80d8964ba3eddd7324869672e73e2190ad42 npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.2.9-alpha-20240524170724-c3df80d8964ba3eddd7324869672e73e2190ad42 npm ↗︎ unpkg ↗︎
@graphql-tools/utils 10.2.1-alpha-20240524170724-c3df80d8964ba3eddd7324869672e73e2190ad42 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented May 20, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 330       ✗ 0  
     data_received..................: 38 MB   3.8 MB/s
     data_sent......................: 141 kB  14 kB/s
     http_req_blocked...............: avg=4.4µs    min=1.94µs   med=2.46µs   max=170.37µs p(90)=3.6µs    p(95)=4.21µs  
     http_req_connecting............: avg=668ns    min=0s       med=0s       max=110.32µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=56.39ms  min=48.28ms  med=52.61ms  max=149.23ms p(90)=63.14ms  p(95)=87.31ms 
       { expected_response:true }...: avg=56.39ms  min=48.28ms  med=52.61ms  max=149.23ms p(90)=63.14ms  p(95)=87.31ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 165
     http_req_receiving.............: avg=135.01µs min=103.59µs med=127.54µs max=374.69µs p(90)=150.52µs p(95)=163.92µs
     http_req_sending...............: avg=26.49µs  min=18.29µs  med=24.1µs   max=360.21µs p(90)=28.27µs  p(95)=33.83µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=56.23ms  min=48.12ms  med=52.42ms  max=148.86ms p(90)=62.98ms  p(95)=87.14ms 
     http_reqs......................: 165     16.456982/s
     iteration_duration.............: avg=60.74ms  min=51.86ms  med=56.8ms   max=153.04ms p(90)=69.96ms  p(95)=91.42ms 
     iterations.....................: 165     16.456982/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented May 20, 2024

💻 Website Preview

The latest changes are available as preview in: https://c0459c31.graphql-tools.pages.dev

Copy link
Collaborator

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gone into the details, but LGTM.

@ardatan ardatan merged commit 7368829 into master May 27, 2024
30 checks passed
@ardatan ardatan deleted the interface-objects-2nd-take branch May 27, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants