Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward operation directives to the subschema requests #6420

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Aug 7, 2024

Pass operation directives correctly to the subschema;

query {
  hello @someDir
}

Closes #6292

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: 40070e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-tools/delegate Patch
@graphql-tools/executor Patch
@graphql-tools/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theguild-bot
Copy link
Collaborator

theguild-bot commented Aug 7, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/delegate 10.0.18-alpha-20240807152531-40070e87cc490c60ae36cef1727cc0e4fd7b6b4d npm ↗︎ unpkg ↗︎
@graphql-tools/executor 1.3.1-alpha-20240807152531-40070e87cc490c60ae36cef1727cc0e4fd7b6b4d npm ↗︎ unpkg ↗︎
@graphql-tools/utils 10.3.4-alpha-20240807152531-40070e87cc490c60ae36cef1727cc0e4fd7b6b4d npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Aug 7, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 328       ✗ 0  
     data_received..................: 38 MB   3.8 MB/s
     data_sent......................: 140 kB  14 kB/s
     http_req_blocked...............: avg=3.97µs  min=2.06µs   med=2.62µs   max=182.49µs p(90)=3.68µs   p(95)=3.87µs  
     http_req_connecting............: avg=754ns   min=0s       med=0s       max=123.77µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=56.63ms min=48.48ms  med=53.03ms  max=151.41ms p(90)=65.17ms  p(95)=87.81ms 
       { expected_response:true }...: avg=56.63ms min=48.48ms  med=53.03ms  max=151.41ms p(90)=65.17ms  p(95)=87.81ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 164
     http_req_receiving.............: avg=132.5µs min=107.06µs med=128.56µs max=268.83µs p(90)=149.56µs p(95)=156.23µs
     http_req_sending...............: avg=25.21µs min=19.48µs  med=23.98µs  max=128.99µs p(90)=29.38µs  p(95)=34.33µs 
     http_req_tls_handshaking.......: avg=0s      min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=56.47ms min=48.3ms   med=52.85ms  max=151.09ms p(90)=65.02ms  p(95)=87.66ms 
     http_reqs......................: 164     16.382829/s
     iteration_duration.............: avg=61.02ms min=52.34ms  med=57.19ms  max=155.24ms p(90)=71.87ms  p(95)=92.96ms 
     iterations.....................: 164     16.382829/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Aug 7, 2024

💻 Website Preview

The latest changes are available as preview in: https://ae931dc7.graphql-tools.pages.dev

@ardatan ardatan merged commit a867bbc into master Aug 7, 2024
29 checks passed
@ardatan ardatan deleted the operation-directives branch August 7, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directives on root fields are lost in subschema requests
2 participants