fix(fetch): call the callback on destroy of Readable adapter

ardatan · Nov 11, 2022 · 188ac01 · 188ac01
1 parent 6748f26
commit 188ac01
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/sixty-ducks-design.md b/.changeset/sixty-ducks-design.md
@@ -0,0 +1,5 @@
+---
+'@whatwg-node/fetch': patch
+---
+
+Fix destroy for Node 18
diff --git a/packages/fetch/dist/readableStreamToReadable.js b/packages/fetch/dist/readableStreamToReadable.js
@@ -12,13 +12,14 @@ module.exports = function readableStreamToReadable(readableStream) {
         }
       })
     },
-    async destroy() {
+    async destroy(err, callback) {
       try {
           reader.cancel();
           reader.releaseLock();
           await readableStream.cancel();
+          callback();
       } catch (error) {
-          console.log(error);
+          callback(error);
       }
     }
   })