Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve streams #1577

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Improve streams #1577

merged 4 commits into from
Aug 19, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Aug 19, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/fetch 0.9.21-alpha-20240819120507-8a0660299c583a6f858387f6a9cd7ed7663a49e2 npm ↗︎ unpkg ↗︎
@whatwg-node/node-fetch 0.5.23-alpha-20240819120507-8a0660299c583a6f858387f6a9cd7ed7663a49e2 npm ↗︎ unpkg ↗︎
@whatwg-node/server 0.9.48-alpha-20240819120507-8a0660299c583a6f858387f6a9cd7ed7663a49e2 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Aug 19, 2024

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.760692 min=80      med=140     max=182      p(90)=161     p(95)=164    
     data_received..................: 21 MB  697 kB/s
     data_sent......................: 14 MB  451 kB/s
     http_req_blocked...............: avg=4.34µs     min=651ns   med=1.51µs  max=6.72ms   p(90)=2.12µs  p(95)=2.52µs 
     http_req_connecting............: avg=2.35µs     min=0s      med=0s      max=6.64ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.87ms    min=3.07ms  med=21.31ms max=705.17ms p(90)=27.68ms p(95)=29.91ms
       { expected_response:true }...: avg=21.87ms    min=3.07ms  med=21.31ms max=705.17ms p(90)=27.68ms p(95)=29.91ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 136680
     http_req_receiving.............: avg=39.5µs     min=11.38µs med=28.02µs max=23.91ms  p(90)=43.2µs  p(95)=51.98µs
     http_req_sending...............: avg=12.54µs    min=4.08µs  med=7.71µs  max=18.52ms  p(90)=11.24µs p(95)=15.96µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.81ms    min=3.04ms  med=21.26ms max=705.09ms p(90)=27.63ms p(95)=29.83ms
     http_reqs......................: 136680 4555.219065/s
     iteration_duration.............: avg=43.86ms    min=12.92ms med=42.61ms max=730.97ms p(90)=48.55ms p(95)=53.97ms
     iterations.....................: 68322  2277.009635/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Aug 19, 2024

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 217570      ✗ 0     
     data_received..................: 22 MB   729 kB/s
     data_sent......................: 8.7 MB  290 kB/s
     http_req_blocked...............: avg=1.47µs   min=921ns    med=1.26µs   max=213.67µs p(90)=1.95µs   p(95)=2.11µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=113.08µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=214.08µs min=162.35µs med=201.75µs max=52.89ms  p(90)=226.25µs p(95)=235.29µs
       { expected_response:true }...: avg=214.08µs min=162.35µs med=201.75µs max=52.89ms  p(90)=226.25µs p(95)=235.29µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 108785
     http_req_receiving.............: avg=25.85µs  min=13.54µs  med=24.85µs  max=1.73ms   p(90)=31.45µs  p(95)=33.23µs 
     http_req_sending...............: avg=6.48µs   min=4.12µs   med=5.89µs   max=575.62µs p(90)=8.2µs    p(95)=8.76µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=181.74µs min=133.37µs med=169.21µs max=52.8ms   p(90)=190.83µs p(95)=199.34µs
     http_reqs......................: 108785  3626.038128/s
     iteration_duration.............: avg=271.34µs min=213.87µs med=257.9µs  max=53.05ms  p(90)=285.91µs p(95)=297.56µs
     iterations.....................: 108785  3626.038128/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Aug 19, 2024

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 291688      ✗ 0     
     data_received..................: 29 MB   958 kB/s
     data_sent......................: 12 MB   389 kB/s
     http_req_blocked...............: avg=1.39µs   min=892ns    med=1.2µs    max=213.87µs p(90)=1.88µs   p(95)=2.06µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=121.3µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=143.12µs min=95.23µs  med=137.3µs  max=7.28ms   p(90)=159.24µs p(95)=166.26µs
       { expected_response:true }...: avg=143.12µs min=95.23µs  med=137.3µs  max=7.28ms   p(90)=159.24µs p(95)=166.26µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 145844
     http_req_receiving.............: avg=24.83µs  min=12.24µs  med=23.68µs  max=3.19ms   p(90)=30.64µs  p(95)=32.88µs 
     http_req_sending...............: avg=6.38µs   min=4.13µs   med=5.69µs   max=289.59µs p(90)=8.17µs   p(95)=8.88µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=111.9µs  min=68.77µs  med=105.79µs max=7.15ms   p(90)=124.46µs p(95)=130.01µs
     http_reqs......................: 145844  4861.288553/s
     iteration_duration.............: avg=201.24µs min=142.35µs med=194.5µs  max=8.11ms   p(90)=220.07µs p(95)=229.96µs
     iterations.....................: 145844  4861.288553/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Aug 19, 2024

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=139.706775 min=52       med=141     max=199      p(90)=160     p(95)=166    
     data_received..................: 21 MB  713 kB/s
     data_sent......................: 14 MB  457 kB/s
     http_req_blocked...............: avg=3.43µs     min=631ns    med=1.35µs  max=12.03ms  p(90)=2.07µs  p(95)=2.37µs 
     http_req_connecting............: avg=1.42µs     min=0s       med=0s      max=5.58ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.38ms    min=367.39µs med=20.7ms  max=903.98ms p(90)=26.81ms p(95)=29.31ms
       { expected_response:true }...: avg=21.38ms    min=367.39µs med=20.7ms  max=903.98ms p(90)=26.81ms p(95)=29.31ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 139822
     http_req_receiving.............: avg=34.91µs    min=9.1µs    med=24.03µs max=23.4ms   p(90)=38.66µs p(95)=45.29µs
     http_req_sending...............: avg=11.45µs    min=3.41µs   med=6.31µs  max=25.11ms  p(90)=9.94µs  p(95)=13.5µs 
     http_req_tls_handshaking.......: avg=0s         min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.34ms    min=322.64µs med=20.66ms max=903.91ms p(90)=26.77ms p(95)=29.21ms
     http_reqs......................: 139822 4660.294112/s
     iteration_duration.............: avg=42.88ms    min=16.99ms  med=41.14ms max=928.24ms p(90)=48.66ms p(95)=53.8ms 
     iterations.....................: 69885  2329.280471/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Aug 19, 2024

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 231116      ✗ 0     
     data_received..................: 23 MB   774 kB/s
     data_sent......................: 9.2 MB  308 kB/s
     http_req_blocked...............: avg=1.38µs   min=932ns    med=1.21µs   max=171.37µs p(90)=1.86µs   p(95)=2.01µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=113.85µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=199.28µs min=150.59µs med=187.18µs max=15.13ms  p(90)=213.16µs p(95)=222.51µs
       { expected_response:true }...: avg=199.28µs min=150.59µs med=187.18µs max=15.13ms  p(90)=213.16µs p(95)=222.51µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 115558
     http_req_receiving.............: avg=24.79µs  min=13.17µs  med=23.31µs  max=757.44µs p(90)=30.38µs  p(95)=32.5µs  
     http_req_sending...............: avg=6.13µs   min=4.15µs   med=5.29µs   max=346.18µs p(90)=8.06µs   p(95)=8.49µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=168.35µs min=124.74µs med=155.98µs max=15.04ms  p(90)=178.82µs p(95)=187.38µs
     http_reqs......................: 115558  3851.790284/s
     iteration_duration.............: avg=255.32µs min=194.47µs med=242.55µs max=15.25ms  p(90)=272.02µs p(95)=283.95µs
     iterations.....................: 115558  3851.790284/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan marked this pull request as ready for review August 19, 2024 12:01
@ardatan ardatan merged commit 99c4344 into master Aug 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant