Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name conflict in library Storage #366

Closed
drmcnelson opened this issue Aug 19, 2024 · 0 comments · Fixed by #370
Closed

Name conflict in library Storage #366

drmcnelson opened this issue Aug 19, 2024 · 0 comments · Fixed by #370
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@drmcnelson
Copy link

drmcnelson commented Aug 19, 2024

The referenced code from Storage/storage_common.h creates a name, debug and this name is visible in global scope.

It therefore conflicts with a name that is ubiquitous in user code.

Please correct this. It is not fair that thousands of users cannot use the name debug and have to change their long established code bases to accommodate this.

Thank you

static inline void debug(const char *fmt, ...)
{
memset(debug_buffer,0x00,256);
va_list va;
va_start (va, fmt);
vsnprintf (debug_buffer,STORAGE_BUFF_DIM, fmt, va);
va_end (va);
if(Serial)
Serial.println(debug_buffer);
}

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Aug 19, 2024
pennam pushed a commit that referenced this issue Oct 3, 2024
…y Storage) (#370)

* renaming storage debug function to avoid clash with user code
@per1234 per1234 added the conclusion: resolved Issue was resolved label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
3 participants