[BREAKING] Support only compatible platform versions #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alessio-perugini
added
type: enhancement
alessio-perugini
requested review from
cmaglie,
umbynos,
per1234,
kittaakos and
MatteoPologruto
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2285 +/- ##
=======================================
Coverage 65.17% 65.17%
=======================================
Files 210 210
Lines 20465 20519 +54
=======================================
+ Hits 13338 13374 +36
- Misses 6005 6022 +17
- Partials 1122 1123 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmaglie
requested changes
Sep 20, 2023
kittaakos
reviewed
Sep 21, 2023
alessio-perugini
force-pushed
the
1889-platform-versions-incompatible-with-host-architecture-are-offered-unnecessarily
branch
2 times, most recently
from
85fa9d8
to
cc1bbab
Compare
kittaakos
reviewed
Sep 21, 2023
alessio-perugini
force-pushed
the
1889-platform-versions-incompatible-with-host-architecture-are-offered-unnecessarily
branch
2 times, most recently
from
18af151
to
cb800ab
Compare
3 tasks
alessio-perugini
force-pushed
the
1889-platform-versions-incompatible-with-host-architecture-are-offered-unnecessarily
branch
6 times, most recently
from
0df532f
to
82bd9e7
Compare
alessio-perugini
force-pushed
the
1889-platform-versions-incompatible-with-host-architecture-are-offered-unnecessarily
branch
2 times, most recently
from
dfb4d40
to
679f014
Compare
alessio-perugini
force-pushed
the
1889-platform-versions-incompatible-with-host-architecture-are-offered-unnecessarily
branch
2 times, most recently
from
d898eea
to
36a4e89
Compare
We leave only the `latest_compatible` field from the API. This field will have the same meaning the the former `latest_compatible_version`. Meaning that if the `latest_compatible` contains a version it is a release that can be installed. However it might happen that we have newer releases that cannot be installed. If the client is interested to show newer-non-installable-releases, the `releases` field can be used to infer that.
alessio-perugini
force-pushed
the
1889-platform-versions-incompatible-with-host-architecture-are-offered-unnecessarily
branch
from
36a4e89
to
14e0d5c
Compare
cmaglie
approved these changes
Nov 9, 2023
alessio-perugini
deleted the
1889-platform-versions-incompatible-with-host-architecture-are-offered-unnecessarily
branch
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
latest_compatiblefield in thecc.arduino.cli.commands.v1.PlatformgRPC message.arduino-cli core install arduino:[email protected]What is the current behavior?
We always try to install (and show) the latest version even if it contains tools not available for the current os.
What is the new behavior?
We show, install, and upgrade a core only if we're sure that all the tools are available for the current OS. Is possible to install a potentially incompatible version providing a specific version of a core.
Does this PR introduce a breaking change, and is titled accordingly?
yup
Other information