-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bye bye legacy! #2317
Merged
Merged
Bye bye legacy! #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2317 +/- ##
==========================================
- Coverage 63.31% 63.04% -0.27%
==========================================
Files 202 200 -2
Lines 19204 19206 +2
==========================================
- Hits 12159 12109 -50
- Misses 6015 6051 +36
- Partials 1030 1046 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmaglie
approved these changes
Sep 15, 2023
alessio-perugini
force-pushed
the
bye_bye_legacy
branch
2 times, most recently
from
September 15, 2023 16:10
9c073c1
to
99ccfb5
Compare
cmaglie
force-pushed
the
refactor_legacy_test_part4
branch
from
September 15, 2023 16:17
e799bad
to
1a6d693
Compare
cmaglie
force-pushed
the
bye_bye_legacy
branch
from
September 15, 2023 16:55
99ccfb5
to
4e1afd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Removing the legacy pkg
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information