Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: some improvements in configuration handling #2364

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 12, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Added some small fix in how the debugger configuration is handled:

  1. Allows non-sequential directives in properties, in particular for debug.server.openocd.scripts.N.
  2. The debug.server.openocd.script directive is ignored if is together with the debug.server.openocd.scripts.N.

What is the current behavior?

  1. The debug.server.openocd.scripts.N sequence was truncated at the first non-consecutive item.
  2. Both script and scripts were concatenated in the resulting config.

What is the new behavior?

  1. The debug.server.openocd.scripts.N sequence is not truncated even if the items are non-consecutive.
  2. scipt and scripts are mutually-exclusive in the config with priority given to scripts.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie self-assigned this Oct 12, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 12, 2023
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, Thanks cris

commands/debug/debug_info.go Show resolved Hide resolved
docs/platform-specification.md Outdated Show resolved Hide resolved
docs/platform-specification.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (748fcf6) 62.92% compared to head (ce64d47) 62.92%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2364   +/-   ##
=======================================
  Coverage   62.92%   62.92%           
=======================================
  Files         203      203           
  Lines       19243    19243           
=======================================
  Hits        12108    12108           
  Misses       6075     6075           
  Partials     1060     1060           
Flag Coverage Δ
unit 62.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
commands/debug/debug_info.go 66.86% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 3a2f9f1 into arduino:master Oct 12, 2023
97 checks passed
@cmaglie cmaglie deleted the cli_debug_improvements branch October 12, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants