Replace mitchellh/go used for macOS notarization
#2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
ubidefeo
approved these changes
Nov 2, 2023
cmaglie
approved these changes
Nov 2, 2023
MatteoPologruto
approved these changes
Nov 8, 2023
umbynos
added a commit
that referenced
this pull request
Nov 8, 2023
* switch to gon fork, apple is deprecating altool to sign * Provider is mandatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
change in tooling see arduino/tooling-project-assets#359
What is the current behavior?
An excellent tool named gon was used to perform the notarization.
the latest stable release of gon uses the altool command-line utility for notarization:
https://github.com/mitchellh/gon/blob/v0.2.5/notarize/upload.go#L41
Using altool for notarization is now deprecated by Apple and support for notarization via this tool is scheduled to be disabled 2023-11-01:
https://developer.apple.com/news/?id=y5mjxqmn
Furthermore, gon was archived
What is the new behavior?
I switched to https://github.com/Bearer/gon that has included mitchellh/gon#72, hoping the maintainers will take the responsibility of maintaining the project.
I added also
AC_PROVIDERenv var which is mandatory with the newnotarytool.Does this PR introduce a breaking change, and is titled accordingly?
no
Other information